2009-04-10 sponge

* More BOB threadgroup fixes, plus debug dump when things go wrong.
    * Fixes to streaminglib, I2CP, which are related to the TG problem.
    * JavaDocs fixups.

core/java/src/net/i2p/client/I2PSessionMuxedImpl.java

@@ -146,8 +146,8 @@ class I2PSessionMuxedImpl extends I2PSessionImpl2 implements I2PSession {
      *         I2PSession.PROTO_STREAMING
      *         I2PSession.PROTO_DATAGRAM
      *         255 disallowed
-     *  @param fromport 1-65535 or 0 for unset
-     *  @param toport 1-65535 or 0 for unset
+     *  @param fromPort 1-65535 or 0 for unset
+     *  @param toPort 1-65535 or 0 for unset
      */
     public boolean sendMessage(Destination dest, byte[] payload, int offset, int size,
                                SessionKey keyUsed, Set tagsSent, long expires,

core/java/src/net/i2p/data/i2cp/I2CPMessageReader.java

@@ -178,7 +178,11 @@ public class I2CPMessageReader {
                     // pause .5 secs when we're paused
                     try {
                         Thread.sleep(500);
-                    } catch (InterruptedException ie) { // nop
+                    } catch (InterruptedException ie) {
+                        // we should break away here.
+                        _log.warn("Breaking away stream", ie);
+                        _listener.disconnected(I2CPMessageReader.this);
+                        cancelRunner();
                     }
                 }
             }

core/java/src/net/i2p/util/ConvertToHash.java

@@ -16,12 +16,15 @@ import net.i2p.data.Hash;
  *    Base32 desthash.b32.i2p
  *    example.i2p
  *
- *  @return null on failure
- *
  *  @author zzz
  */
 public class ConvertToHash {
     
+    /**
+     *  Convert any kind of destination String to a hash
+     *
+     *  @return null on failure
+     */
     public static Hash getHash(String peer) {
         if (peer == null)
             return null;