* Convert some inner classes to static (findbugs)

This commit is contained in:
zzz
2009-01-31 14:27:45 +00:00
parent 951f082884
commit 395baf0274
5 changed files with 9 additions and 9 deletions

View File

@ -361,24 +361,24 @@ public class SOCKS5Server extends SOCKSServer {
/* /*
* Some namespaces to enclose SOCKS protocol codes * Some namespaces to enclose SOCKS protocol codes
*/ */
private class Method { private static class Method {
private static final int NO_AUTH_REQUIRED = 0x00; private static final int NO_AUTH_REQUIRED = 0x00;
private static final int NO_ACCEPTABLE_METHODS = 0xff; private static final int NO_ACCEPTABLE_METHODS = 0xff;
} }
private class AddressType { private static class AddressType {
private static final int IPV4 = 0x01; private static final int IPV4 = 0x01;
private static final int DOMAINNAME = 0x03; private static final int DOMAINNAME = 0x03;
private static final int IPV6 = 0x04; private static final int IPV6 = 0x04;
} }
private class Command { private static class Command {
private static final int CONNECT = 0x01; private static final int CONNECT = 0x01;
private static final int BIND = 0x02; private static final int BIND = 0x02;
private static final int UDP_ASSOCIATE = 0x03; private static final int UDP_ASSOCIATE = 0x03;
} }
private class Reply { private static class Reply {
private static final int SUCCEEDED = 0x00; private static final int SUCCEEDED = 0x00;
private static final int GENERAL_SOCKS_SERVER_FAILURE = 0x01; private static final int GENERAL_SOCKS_SERVER_FAILURE = 0x01;
private static final int CONNECTION_NOT_ALLOWED_BY_RULESET = 0x02; private static final int CONNECTION_NOT_ALLOWED_BY_RULESET = 0x02;

View File

@ -156,7 +156,7 @@ public class RequestLeaseSetMessage extends I2CPMessageImpl {
return buf.toString(); return buf.toString();
} }
private class TunnelEndpoint { private static class TunnelEndpoint {
private Hash _router; private Hash _router;
private TunnelId _tunnelId; private TunnelId _tunnelId;

View File

@ -256,7 +256,7 @@ public class Blocklist {
} }
} }
private class Entry { private static class Entry {
String comment; String comment;
byte ip1[]; byte ip1[];
byte ip2[]; byte ip2[];

View File

@ -36,7 +36,7 @@ public class Shitlist {
private RouterContext _context; private RouterContext _context;
private Map _entries; private Map _entries;
private class Entry { private static class Entry {
/** when it should expire, per the i2p clock */ /** when it should expire, per the i2p clock */
long expireOn; long expireOn;
/** why they were shitlisted */ /** why they were shitlisted */

View File

@ -376,7 +376,7 @@ public class TunnelPoolManager implements TunnelManagerFacade {
_context.jobQueue().addJob(new BootstrapPool(_context, _outboundExploratory)); _context.jobQueue().addJob(new BootstrapPool(_context, _outboundExploratory));
} }
private class BootstrapPool extends JobImpl { private static class BootstrapPool extends JobImpl {
private TunnelPool _pool; private TunnelPool _pool;
public BootstrapPool(RouterContext ctx, TunnelPool pool) { public BootstrapPool(RouterContext ctx, TunnelPool pool) {
super(ctx); super(ctx);