diff --git a/apps/heartbeat/java/src/net/i2p/heartbeat/ClientEngine.java b/apps/heartbeat/java/src/net/i2p/heartbeat/ClientEngine.java index 15caa0caf..15230f40a 100644 --- a/apps/heartbeat/java/src/net/i2p/heartbeat/ClientEngine.java +++ b/apps/heartbeat/java/src/net/i2p/heartbeat/ClientEngine.java @@ -90,7 +90,7 @@ class ClientEngine { /** our actual heartbeat pumper - this drives the test */ private class ClientRunner implements Runnable { - /* (non-Javadoc) + /** * @see java.lang.Runnable#run() */ public void run() { diff --git a/apps/heartbeat/java/src/net/i2p/heartbeat/Heartbeat.java b/apps/heartbeat/java/src/net/i2p/heartbeat/Heartbeat.java index 5a6fe476a..c577945f6 100644 --- a/apps/heartbeat/java/src/net/i2p/heartbeat/Heartbeat.java +++ b/apps/heartbeat/java/src/net/i2p/heartbeat/Heartbeat.java @@ -157,7 +157,7 @@ public class Heartbeat { } /** disconnect from the network */ - private void disconnect() { + private void disconnect() { /* UNUSED */ _adapter.disconnect(); } diff --git a/apps/heartbeat/java/src/net/i2p/heartbeat/I2PAdapter.java b/apps/heartbeat/java/src/net/i2p/heartbeat/I2PAdapter.java index e0fab90d7..35c157c7b 100644 --- a/apps/heartbeat/java/src/net/i2p/heartbeat/I2PAdapter.java +++ b/apps/heartbeat/java/src/net/i2p/heartbeat/I2PAdapter.java @@ -46,7 +46,7 @@ class I2PAdapter { /** how do we talk to the router */ private I2PSession _session; /** object that receives our i2cp notifications from the session and tells us */ - private I2PListener _i2pListener; + private I2PListener _i2pListener; /* UNUSED */ /** * This config property tells us where the private destination data for our @@ -578,14 +578,14 @@ class I2PAdapter { * @see net.i2p.client.I2PSessionListener#errorOccurred(net.i2p.client.I2PSession, java.lang.String, java.lang.Throwable) */ public void errorOccurred(I2PSession session, String message, Throwable error) { - if (_log.shouldLog(Log.ERROR)) _log.error("Error occurred", error); + if (_log.shouldLog(Log.ERROR)) _log.error("Error occurred: " + message, error); } /* (non-Javadoc) * @see net.i2p.client.I2PSessionListener#reportAbuse(net.i2p.client.I2PSession, int) */ public void reportAbuse(I2PSession session, int severity) { - if (_log.shouldLog(Log.ERROR)) _log.error("Abuse reported"); + if (_log.shouldLog(Log.ERROR)) _log.error("Abuse reported with severity " + String.valueOf(severity)); } /* (non-Javadoc) diff --git a/apps/heartbeat/java/src/net/i2p/heartbeat/PeerData.java b/apps/heartbeat/java/src/net/i2p/heartbeat/PeerData.java index d36a41e84..052cd09b9 100644 --- a/apps/heartbeat/java/src/net/i2p/heartbeat/PeerData.java +++ b/apps/heartbeat/java/src/net/i2p/heartbeat/PeerData.java @@ -103,6 +103,11 @@ public class PeerData { * @return when the test began */ public long getSessionStart() { return _sessionStart; } + + /** + * sets when the test began + * @param when when it began + */ public void setSessionStart(long when) { _sessionStart = when; } /** @@ -332,6 +337,11 @@ public class PeerData { * @return the time the ping was sent */ public long getPingSent() { return _pingSent; } + + /** + * sets when we sent this ping + * @param when when we sent the ping + */ public void setPingSent(long when) { _pingSent = when; } /** diff --git a/apps/heartbeat/java/src/net/i2p/heartbeat/gui/HeartbeatControlPane.java b/apps/heartbeat/java/src/net/i2p/heartbeat/gui/HeartbeatControlPane.java index d2d69c32b..d28144731 100644 --- a/apps/heartbeat/java/src/net/i2p/heartbeat/gui/HeartbeatControlPane.java +++ b/apps/heartbeat/java/src/net/i2p/heartbeat/gui/HeartbeatControlPane.java @@ -21,7 +21,7 @@ class HeartbeatControlPane extends JPanel { private HeartbeatMonitorGUI _gui; private JTabbedPane _configPane; private final static Color WHITE = new Color(255, 255, 255); - private final static Color LIGHT_BLUE = new Color(180, 180, 255); + private final static Color LIGHT_BLUE = new Color(180, 180, 255); /* UNUSED */ private final static Color BLACK = new Color(0, 0, 0); private Color _background = WHITE; private Color _foreground = BLACK; diff --git a/apps/heartbeat/java/src/net/i2p/heartbeat/gui/HeartbeatMonitor.java b/apps/heartbeat/java/src/net/i2p/heartbeat/gui/HeartbeatMonitor.java index 57a7999ab..827d93ef6 100644 --- a/apps/heartbeat/java/src/net/i2p/heartbeat/gui/HeartbeatMonitor.java +++ b/apps/heartbeat/java/src/net/i2p/heartbeat/gui/HeartbeatMonitor.java @@ -88,7 +88,9 @@ public class HeartbeatMonitor implements PeerPlotStateFetcher.FetchStateReceptor _gui.stateUpdated(); } - /** store the config defining what peer tests we are monitoring (and how to render) */ + /** + * store the config defining what peer tests we are monitoring (and how to render) + */ void storeConfig() {} /** @@ -103,6 +105,10 @@ public class HeartbeatMonitor implements PeerPlotStateFetcher.FetchStateReceptor new HeartbeatMonitor().runMonitor(); } + /** + * Called when the config is updated + * @param config the updated config + */ public void configUpdated(PeerPlotConfig config) { _log.debug("Config updated, revamping the gui"); _gui.stateUpdated(); diff --git a/apps/heartbeat/java/src/net/i2p/heartbeat/gui/JFreeChartAdapter.java b/apps/heartbeat/java/src/net/i2p/heartbeat/gui/JFreeChartAdapter.java index 760b72cf9..80ef31ca7 100644 --- a/apps/heartbeat/java/src/net/i2p/heartbeat/gui/JFreeChartAdapter.java +++ b/apps/heartbeat/java/src/net/i2p/heartbeat/gui/JFreeChartAdapter.java @@ -19,7 +19,7 @@ import net.i2p.heartbeat.PeerData; import net.i2p.util.Log; class JFreeChartAdapter { - private final static Log _log = new Log(JFreeChartAdapter.class); + private final static Log _log = new Log(JFreeChartAdapter.class); /* UNUSED */ private final static Color WHITE = new Color(255, 255, 255); ChartPanel createPanel(HeartbeatMonitorState state) { @@ -45,7 +45,7 @@ class JFreeChartAdapter { updateLines(plot, state); } - private long getFirst(HeartbeatMonitorState state) { + private long getFirst(HeartbeatMonitorState state) { /* UNUSED */ long first = -1; for (int i = 0; i < state.getTestCount(); i++) { List dataPoints = state.getTest(i).getCurrentData().getDataPoints(); @@ -116,6 +116,7 @@ class JFreeChartAdapter { } /** + * @param col the collection of xy series to add to * @param config preferences for how to display this test * @param lineName minimal name of the test (e.g. "jxHa.32KB.60s") * @param data List of PeerData.EventDataPoint describing all of the events in the test @@ -144,6 +145,7 @@ class JFreeChartAdapter { /** * Add a data series for each average that we're configured to render * + * @param col the collection of xy series to add to * @param config preferences for how to display this test * @param lineName minimal name of the test (e.g. "jxHa.32KB.60s") * @param data List of PeerData.EventDataPoint describing all of the events in the test diff --git a/apps/heartbeat/java/src/net/i2p/heartbeat/gui/JFreeChartHeartbeatPlotPane.java b/apps/heartbeat/java/src/net/i2p/heartbeat/gui/JFreeChartHeartbeatPlotPane.java index bcef3c6d5..7075c37d1 100644 --- a/apps/heartbeat/java/src/net/i2p/heartbeat/gui/JFreeChartHeartbeatPlotPane.java +++ b/apps/heartbeat/java/src/net/i2p/heartbeat/gui/JFreeChartHeartbeatPlotPane.java @@ -14,14 +14,21 @@ import net.i2p.util.Log; * */ class JFreeChartHeartbeatPlotPane extends HeartbeatPlotPane { - private final static Log _log = new Log(JFreeChartHeartbeatPlotPane.class); + private final static Log _log = new Log(JFreeChartHeartbeatPlotPane.class); /* UNUSED */ private ChartPanel _panel; private JFreeChartAdapter _adapter; - + + /** + * Creates a JFreeChart plot pane for the given gui + * @param gui the heartbeat monitor gui + */ public JFreeChartHeartbeatPlotPane(HeartbeatMonitorGUI gui) { super(gui); } + /** + * Called when the state is updated + */ public void stateUpdated() { if (_panel == null) { remove(0); // remove the dummy diff --git a/apps/heartbeat/java/src/net/i2p/heartbeat/gui/PeerPlotConfig.java b/apps/heartbeat/java/src/net/i2p/heartbeat/gui/PeerPlotConfig.java index 230e3a574..27d8533ae 100644 --- a/apps/heartbeat/java/src/net/i2p/heartbeat/gui/PeerPlotConfig.java +++ b/apps/heartbeat/java/src/net/i2p/heartbeat/gui/PeerPlotConfig.java @@ -18,7 +18,7 @@ import net.i2p.util.Log; * Configure how we want to render a particular clientConfig in the GUI */ class PeerPlotConfig { - private final static Log _log = new Log(PeerPlotConfig.class); + private final static Log _log = new Log(PeerPlotConfig.class); /* UNUSED */ /** where can we find the current state/data (either as a filename or a URL)? */ private String _location; /** what test are we defining the plot data for? */ @@ -170,8 +170,8 @@ class PeerPlotConfig { Destination peer = getClientConfig().getPeer(); if (peer == null) return "????"; - else - return peer.calculateHash().toBase64().substring(0, 4); + + return peer.calculateHash().toBase64().substring(0, 4); } /** @@ -196,8 +196,8 @@ class PeerPlotConfig { int bytes = getClientConfig().getSendSize(); if (bytes < 1024) return bytes + "b"; - else - return bytes/1024 + "kb"; + + return bytes/1024 + "kb"; } /** diff --git a/apps/heartbeat/java/src/net/i2p/heartbeat/gui/PeerPlotConfigPane.java b/apps/heartbeat/java/src/net/i2p/heartbeat/gui/PeerPlotConfigPane.java index 226eb2df8..aa0ab1cde 100644 --- a/apps/heartbeat/java/src/net/i2p/heartbeat/gui/PeerPlotConfigPane.java +++ b/apps/heartbeat/java/src/net/i2p/heartbeat/gui/PeerPlotConfigPane.java @@ -243,6 +243,7 @@ class PeerPlotConfigPane extends JPanel implements PeerPlotConfig.UpdateListener _minutes = minutes; _button = button; } + /* (non-Javadoc) * @see java.awt.event.ActionListener#actionPerformed(java.awt.event.ActionEvent) */ diff --git a/apps/heartbeat/java/src/net/i2p/heartbeat/gui/PeerPlotStateFetcher.java b/apps/heartbeat/java/src/net/i2p/heartbeat/gui/PeerPlotStateFetcher.java index 770883bcc..82b5aa73a 100644 --- a/apps/heartbeat/java/src/net/i2p/heartbeat/gui/PeerPlotStateFetcher.java +++ b/apps/heartbeat/java/src/net/i2p/heartbeat/gui/PeerPlotStateFetcher.java @@ -326,7 +326,7 @@ class PeerPlotStateFetcher { } } - private void fakeRun() { + private void fakeRun() { /* UNUSED */ try { Destination peer = new Destination(); Destination us = new Destination(); diff --git a/apps/heartbeat/java/src/net/i2p/heartbeat/gui/StaticPeerData.java b/apps/heartbeat/java/src/net/i2p/heartbeat/gui/StaticPeerData.java index e0b36b094..bcd20ca80 100644 --- a/apps/heartbeat/java/src/net/i2p/heartbeat/gui/StaticPeerData.java +++ b/apps/heartbeat/java/src/net/i2p/heartbeat/gui/StaticPeerData.java @@ -94,8 +94,8 @@ class StaticPeerData extends PeerData { Integer i = (Integer)_averageSendTimes.get(new Integer(period)); if (i == null) return -1; - else - return i.doubleValue(); + + return i.doubleValue(); } @@ -109,8 +109,8 @@ class StaticPeerData extends PeerData { Integer i = (Integer)_averageReceiveTimes.get(new Integer(period)); if (i == null) return -1; - else - return i.doubleValue(); + + return i.doubleValue(); } /** @@ -123,8 +123,8 @@ class StaticPeerData extends PeerData { Integer i = (Integer)_lostMessages.get(new Integer(period)); if (i == null) return -1; - else - return i.doubleValue(); + + return i.doubleValue(); } /* (non-Javadoc) diff --git a/apps/httptunnel/java/src/net/i2p/httptunnel/HTTPListener.java b/apps/httptunnel/java/src/net/i2p/httptunnel/HTTPListener.java index 60f6752c8..34ad8faa1 100644 --- a/apps/httptunnel/java/src/net/i2p/httptunnel/HTTPListener.java +++ b/apps/httptunnel/java/src/net/i2p/httptunnel/HTTPListener.java @@ -57,14 +57,14 @@ public class HTTPListener extends Thread { * @return Whether this is the first proxy use, no doubt. */ public boolean firstProxyUse() { - // FIXME: check a config option here - if (true) return false; + if (true) return false; // FIXME: check a config option here + if (proxyUsed) { return false; - } else { - proxyUsed = true; - return true; } + + proxyUsed = true; + return true; } /** diff --git a/apps/httptunnel/java/src/net/i2p/httptunnel/handler/ErrorHandler.java b/apps/httptunnel/java/src/net/i2p/httptunnel/handler/ErrorHandler.java index c06e6d04d..35c296281 100644 --- a/apps/httptunnel/java/src/net/i2p/httptunnel/handler/ErrorHandler.java +++ b/apps/httptunnel/java/src/net/i2p/httptunnel/handler/ErrorHandler.java @@ -12,7 +12,7 @@ import net.i2p.util.Log; */ public class ErrorHandler { - private static final Log _log = new Log(ErrorHandler.class); + private static final Log _log = new Log(ErrorHandler.class); /* UNUSED */ /* package private */ErrorHandler() { diff --git a/apps/httptunnel/java/src/net/i2p/httptunnel/handler/LocalHandler.java b/apps/httptunnel/java/src/net/i2p/httptunnel/handler/LocalHandler.java index 5726af880..b2142c610 100644 --- a/apps/httptunnel/java/src/net/i2p/httptunnel/handler/LocalHandler.java +++ b/apps/httptunnel/java/src/net/i2p/httptunnel/handler/LocalHandler.java @@ -13,7 +13,7 @@ import net.i2p.util.Log; */ public class LocalHandler { - private static final Log _log = new Log(LocalHandler.class); + private static final Log _log = new Log(LocalHandler.class); /* UNUSED */ /* package private */LocalHandler() { } diff --git a/apps/httptunnel/java/src/net/i2p/httptunnel/handler/ProxyHandler.java b/apps/httptunnel/java/src/net/i2p/httptunnel/handler/ProxyHandler.java index 24e349ea0..a0e55e931 100644 --- a/apps/httptunnel/java/src/net/i2p/httptunnel/handler/ProxyHandler.java +++ b/apps/httptunnel/java/src/net/i2p/httptunnel/handler/ProxyHandler.java @@ -18,7 +18,7 @@ import net.i2p.util.Log; */ public class ProxyHandler extends EepHandler { - private static final Log _log = new Log(ErrorHandler.class); + private static final Log _log = new Log(ErrorHandler.class); /* UNUSED */ private static I2PAppContext _context = new I2PAppContext(); /* package private */ProxyHandler(ErrorHandler eh) { diff --git a/apps/httptunnel/java/src/net/i2p/httptunnel/handler/RootHandler.java b/apps/httptunnel/java/src/net/i2p/httptunnel/handler/RootHandler.java index 4f94d4744..1cb0b2694 100644 --- a/apps/httptunnel/java/src/net/i2p/httptunnel/handler/RootHandler.java +++ b/apps/httptunnel/java/src/net/i2p/httptunnel/handler/RootHandler.java @@ -12,7 +12,7 @@ import net.i2p.util.Log; */ public class RootHandler { - private static final Log _log = new Log(RootHandler.class); + private static final Log _log = new Log(RootHandler.class); /* UNUSED */ private RootHandler() { errorHandler = new ErrorHandler(); @@ -60,26 +60,24 @@ public class RootHandler { url = url.substring(7); pos = url.indexOf("/"); String host; - String rest; + if (pos == -1) { errorHandler.handle(req, httpl, out, "No host end in URL"); return; + } + + host = url.substring(0, pos); + url = url.substring(pos); + if ("i2p".equals(host) || "i2p.i2p".equals(host)) { + // normal request; go on below... + } else if (host.endsWith(".i2p")) { + // "old" service request, send a redirect... + out.write(("HTTP/1.1 302 Moved\r\nLocation: " + "http://i2p.i2p/" + host + url + "\r\n\r\n").getBytes("ISO-8859-1")); + return; } else { - host = url.substring(0, pos); - url = url.substring(pos); - if ("i2p".equals(host) || "i2p.i2p".equals(host)) { - // normal request; go on below... - } else if (host.endsWith(".i2p")) { - // "old" service request, send a redirect... - out - .write(("HTTP/1.1 302 Moved\r\nLocation: " + "http://i2p.i2p/" + host + url + "\r\n\r\n") - .getBytes("ISO-8859-1")); - return; - } else { - // this is for proxying to the real web - proxyHandler.handle(req, httpl, out /*, true */); - return; - } + // this is for proxying to the real web + proxyHandler.handle(req, httpl, out /*, true */); + return; } } if (url.equals("/")) { // main page diff --git a/apps/i2ptunnel/java/src/net/i2p/i2ptunnel/BufferLogger.java b/apps/i2ptunnel/java/src/net/i2p/i2ptunnel/BufferLogger.java index 6c4dd315a..29f954fc4 100644 --- a/apps/i2ptunnel/java/src/net/i2p/i2ptunnel/BufferLogger.java +++ b/apps/i2ptunnel/java/src/net/i2p/i2ptunnel/BufferLogger.java @@ -17,6 +17,9 @@ class BufferLogger implements Logging { private ByteArrayOutputStream _baos; private boolean _ignore; + /** + * Constructs a buffered logger. + */ public BufferLogger() { _baos = new ByteArrayOutputStream(512); _ignore = false; @@ -24,11 +27,15 @@ class BufferLogger implements Logging { private final static String EMPTY = ""; + /** + * Retrieves the buffer + * @return the buffer + */ public String getBuffer() { if (_ignore) return EMPTY; - else - return new String(_baos.toByteArray()); + + return new String(_baos.toByteArray()); } /**