cleanups after review, ticket 390

apps/routerconsole/java/src/net/i2p/router/web/PluginUpdateHandler.java

@@ -144,6 +144,7 @@ public class PluginUpdateHandler extends UpdateHandler {
             }
             buf.append(": ");
             buf.append(_("{0}B transferred", DataHelper.formatSize2(currentWrite + alreadyTransferred)));
+            buf.append("</b>");
             updateStatus(buf.toString());
         }
 

core/java/src/net/i2p/client/DestReplyMessageHandler.java

@@ -26,11 +26,13 @@ class DestReplyMessageHandler extends HandlerImpl {
             _log.debug("Handle message " + message);
         DestReplyMessage msg = (DestReplyMessage) message;
         Destination d = msg.getDestination();
-        if (d != null)
+        if (d != null) {
             session.destReceived(d);
+        } else {
             Hash h = msg.getHash();
             if (h != null)
                 session.destLookupFailed(h);
+        }
         // else let it time out
     }
 }

core/java/src/net/i2p/data/SimpleDataStructure.java

@@ -75,7 +75,7 @@ public abstract class SimpleDataStructure extends DataStructureImpl {
 
     /**
      * Sets the data.
-     * @param data of correct length, or null
+     * @param in the stream to read
      * @throws RuntimeException if data already set.
      */
     public void readBytes(InputStream in) throws DataFormatException, IOException {

installer/resources/themes/console/dark/console.css

@@ -865,7 +865,7 @@ input:active {
      color: #EE9;
 }
 
-input[type=text] {
+input[type=text], input[type=password] {
      background: #000;
      color: #EE9;
      margin: 5px 10px;
@@ -881,7 +881,7 @@ input[type=text] {
      box-shadow: inset 1px 1px 1px 0px #000;
 }
 
-input[type=text]:active, input[type=text]:hover {
+input[type=text]:active, input[type=text]:hover, input[type=password]:active, input[type=password]:hover {
      background: #000;
 }
 

installer/resources/themes/console/light/console.css

@@ -138,7 +138,6 @@ div.routersummary h3 {
      -khtml-border-radius: 3px;
      border-radius: 3px;
      -moz-box-shadow: 0px 1px 5px #bbf;
-     text-shadow: 0px 1px 1px #77f;
      -moz-box-shadow: outset 0px 0px 2px 1px #bbf;
      -khtml-box-shadow: outset 0px 0px 2px 1px #bbf;
      box-shadow: outset 0px 0px 2px 1px #bbf;
@@ -726,7 +725,6 @@ h1 {
      font: normal bold 16pt/120% "Lucida Sans Unicode", "Bitstream Vera Sans", Verdana, Tahoma, Helvetica, sans-serif;
      letter-spacing: 0.15em;
      text-transform: uppercase;
-     text-shadow: 0px 1px 1px #77f;
      -moz-box-shadow: inset 0px 0px 1px 1px #bbf;
      -khtml-box-shadow: inset 0px 0px 1px 1px #bbf;
      box-shadow: inset 0px 0px 1px 1px #bbf;
@@ -744,7 +742,6 @@ h2 {
      color: #115;
      letter-spacing: 0.07em;
      background: url('images/header.png') center center repeat-x;
-     text-shadow: 0px 1px 1px #99f;
      padding: 10px;
      wordwrap: none;
      border: 1px solid #115;
@@ -756,7 +753,6 @@ h2 {
      -khtml-box-shadow: 0 2px 1px 1px rgba(176, 176, 216, 0.4);
      box-shadow: 0 2px 1px 1px rgba(176, 176, 216, 0.4);
      word-wrap: break-word;
-     text-transform: uppercase;
      opacity: 1;
 }
 
@@ -792,8 +788,6 @@ h3 {
      -moz-border-radius: 0 4px 4px 0;
      -khtml-border-radius: 0 4px 4px 0;
      background: url('images/header.png') center center repeat-x !important;
-     text-transform: uppercase;
-     text-shadow: 0px 1px 1px #99f;
      font-size: 11pt;
      color: #115;
      -moz-box-shadow: 0 2px 1px 1px rgba(176, 176, 216, 0.4);
@@ -924,7 +918,7 @@ input:active {
      box-shadow: inset 0px 0px 0px 1px #f60;
 }
 
-input[type=text] {
+input[type=text], input[type=password] {
      background: #ffe;
      color: #001;
      margin: 5px 10px 5px 10px;
@@ -1014,9 +1008,7 @@ form {}
      margin: -5px 0 5px 0; 
      padding: 7px;
      background: url("images/header.png") repeat scroll center center #eef;
-     text-shadow: 0 1px #99f;
      letter-spacing: 0em !important;
-     text-transform: capitalize;
 }
 
 div.joblog {

installer/resources/themes/console/light/default.css

@@ -51,12 +51,10 @@ h4 {
      margin: 5px 0 15px 0;
      padding: 5px 10px;
      background: url(images/header.png) repeat-x center center;
-     text-transform: uppercase;
      letter-spacing: 0.07em;
      -moz-border-radius: 4px;
      -khtml-border-radius: 4px;
      border-radius: 4px;
-     text-shadow: 0px 1px 1px #77f;
      -moz-box-shadow: 0 2px 1px 1px rgba(176, 176, 216, 0.4);
      -khtml-box-shadow: 0 2px 1px 1px rgba(176, 176, 216, 0.4);
      box-shadow: 0 2px 1px 1px rgba(176, 176, 216, 0.4);

installer/resources/themes/console/midnight/console.css

@@ -744,7 +744,7 @@ input {
      vertical-align: middle;
 }
 
-input[type=text] {
+input[type=text], input[type=password] {
      margin: 3px 5px 3px 5px;
      vertical-align: middle;
 }
@@ -754,7 +754,7 @@ select {
      vertical-align: middle;
 }
 
-input[type=text], select {
+input[type=text], input[type=password] select {
      background: #001;
      color: #eef;
      border: 1px solid #99f;