change restart/shutdown/update links to buttons

apps/routerconsole/java/src/net/i2p/router/web/ConfigClientsHelper.java

@@ -79,7 +79,7 @@ public class ConfigClientsHelper {
         }
         buf.append("/></td><td>&nbsp");
         if (!enabled) {
-            buf.append("<button type=\"submit\" name=\"action\" value=\"Start ").append(index).append("\" />Start</button>");
+            buf.append("<button type=\"submit\" name=\"action\" value=\"Start ").append(index).append("\" >Start</button>");
         }
         buf.append("&nbsp</td><td>").append(desc).append("</td></tr>\n");
     }

apps/routerconsole/java/src/net/i2p/router/web/ConfigRestartBean.java

@@ -1,5 +1,7 @@
 package net.i2p.router.web;
 
+import java.util.StringTokenizer;
+
 import net.i2p.data.DataHelper;
 import net.i2p.router.Router;
 import net.i2p.router.RouterContext;
@@ -47,27 +49,35 @@ public class ConfigRestartBean {
                 return "<b>Shutdown imminent</b>";
             } else {
                 return "<b>Shutdown in " + DataHelper.formatDuration(timeRemaining) + "</b><br />"
-                     + "<a href=\"" + urlBase + "?consoleNonce=" + systemNonce + "&amp;action=shutdownImmediate\">Shutdown immediately</a><br />"
+                     + buttons(urlBase, systemNonce, "shutdownImmediate,Shutdown immediately,cancelShutdown,Cancel shutdown");
-                     + "<a href=\"" + urlBase + "?consoleNonce=" + systemNonce + "&amp;action=cancelShutdown\">Cancel shutdown</a> ";
             }
         } else if (restarting) {
             if (timeRemaining <= 0) {
                 return "<b>Restart imminent</b>";
             } else {
                 return "<b>Restart in " + DataHelper.formatDuration(timeRemaining) + "</b><br />"
-                     + "<a href=\"" + urlBase + "?consoleNonce=" + systemNonce + "&amp;action=restartImmediate\">Restart immediately</a><br />"
+                     + buttons(urlBase, systemNonce, "restartImmediate,Restart immediately,cancelShutdown,Cancel restart");
-                     + "<a href=\"" + urlBase + "?consoleNonce=" + systemNonce + "&amp;action=cancelShutdown\">Cancel restart</a> ";
             }
         } else {
-            String shutdown = "<a href=\"" + urlBase + "?consoleNonce=" + systemNonce + "&amp;action=shutdown\" title=\"Graceful shutdown\">Shutdown</a>";
             if (System.getProperty("wrapper.version") != null)
-                return "<a href=\"" + urlBase + "?consoleNonce=" + systemNonce + "&amp;action=restart\" title=\"Graceful restart\">Restart</a> "
+                return buttons(urlBase, systemNonce, "restart,Restart,shutdown,Shutdown");
-                       + shutdown;
             else
-                return shutdown;
+                return buttons(urlBase, systemNonce, "shutdown,Shutdown");
         }
     }
     
+    /** @param s value,label,... pairs */
+    private static String buttons(String url, String nonce, String s) {
+        StringBuffer buf = new StringBuffer(128);
+        StringTokenizer tok = new StringTokenizer(s, ",");
+        buf.append("<form action=\"").append(url).append("\" method=\"GET\">\n");
+        buf.append("<input type=\"hidden\" name=\"consoleNonce\" value=\"").append(nonce).append("\" >\n");
+        while (tok.hasMoreTokens())
+            buf.append("<button type=\"submit\" name=\"action\" value=\"").append(tok.nextToken()).append("\" >").append(tok.nextToken()).append("</button>\n");
+        buf.append("</form>\n");
+        return buf.toString();
+    }
+
     private static boolean isShuttingDown(RouterContext ctx) {
         return Router.EXIT_GRACEFUL == ctx.router().scheduledGracefulExitCode();
     }

apps/routerconsole/jsp/summary.jsp

@@ -7,6 +7,9 @@
 <jsp:useBean class="net.i2p.router.web.UpdateHandler" id="update" scope="request" />
 <jsp:setProperty name="update" property="*" />
 <jsp:setProperty name="update" property="contextId" value="<%=(String)session.getAttribute("i2p.contextId")%>" />
+<jsp:useBean class="net.i2p.router.web.ConfigUpdateHelper" id="uhelper" scope="request" />
+<jsp:setProperty name="uhelper" property="*" />
+<jsp:setProperty name="uhelper" property="contextId" value="<%=(String)session.getAttribute("i2p.contextId")%>" />
 
 <div class="routersummary">
  <u><b>General</b></u><br />
@@ -25,15 +28,15 @@
             if (prev != null) System.setProperty("net.i2p.router.web.UpdateHandler.noncePrev", prev);
             System.setProperty("net.i2p.router.web.UpdateHandler.nonce", nonce+"");
             String uri = request.getRequestURI();
-            if (uri.indexOf('?') > 0)
+            out.print("<p><form action=\"" + uri + "\" method=\"GET\">\n");
-                uri = uri + "&updateNonce=" + nonce;
+            out.print("<input type=\"hidden\" name=\"updateNonce\" value=\"" + nonce + "\" >\n");
-            else
+            out.print("<input type=\"submit\" value=\"Download " + uhelper.getUpdateVersion() + " Update\" ></form></p>\n");
-                uri = uri + "?updateNonce=" + nonce;
-            out.print("<br /><a href=\"" + uri + "\">Update available</a>");
         }
     }
  %>
- <br /><%=net.i2p.router.web.ConfigRestartBean.renderStatus(request.getRequestURI(), request.getParameter("action"), request.getParameter("consoleNonce"))%>
+ <p>
+ <%=net.i2p.router.web.ConfigRestartBean.renderStatus(request.getRequestURI(), request.getParameter("action"), request.getParameter("consoleNonce"))%>
+ </p>
  <hr />
  
  <u><b><a href="peers.jsp">Peers</a></b></u><br />