From a61b9c359a07b15f5d29a113d0f97b88fee4f591 Mon Sep 17 00:00:00 2001
From: zzz <zzz@i2pmail.org>
Date: Mon, 10 Oct 2022 11:26:32 -0400
Subject: [PATCH] SAMv3: Add note about session IDs

add link to bitcoin code
---
 i2p2www/pages/site/docs/api/samv3.html | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/i2p2www/pages/site/docs/api/samv3.html b/i2p2www/pages/site/docs/api/samv3.html
index f5e53887..621cd293 100644
--- a/i2p2www/pages/site/docs/api/samv3.html
+++ b/i2p2www/pages/site/docs/api/samv3.html
@@ -1,6 +1,6 @@
 {% extends "global/layout.html" %}
 {% block title %}SAM V3{% endblock %}
-{% block lastupdated %}2022-09{% endblock %}
+{% block lastupdated %}2022-10{% endblock %}
 {% block accuratefor %}1.9.0{% endblock %}
 {% block content %}
 <p>SAM is a simple client protocol for interacting with I2P.
@@ -217,6 +217,15 @@ Deprecated versions:
 <td>yes</td>
 <td><a href="https://notabug.org/acetone/i2pSAM-Qt">notabug.org/acetone/i2pSAM-Qt</a></td>
 </tr>
+<tr class="odd">
+<td>bitcoin</td>
+<td>C++</td>
+<td>3.1</td>
+<td>yes</td>
+<td>no</td>
+<td>no</td>
+<td><a href="https://github.com/bitcoin/bitcoin/blob/master/src/i2p.cpp">source (not a library, but good reference code)</a></td>
+</tr>
 </tbody>
 </table>
 
@@ -521,6 +530,9 @@ and the session terminates when the socket is disconnected.
 </p><p>
 Each registered I2P Destination is uniquely associated with a session ID
 (or nickname).
+Session IDs, including subsession IDs for PRIMARY sessions, must be globally unique
+on the SAM server. To prevent possible ID collisions with other clients,
+best practice is for the client to generate IDs randomly.
 
 </p><p>
 Each session is uniquely associated with: