From dff21314ba98a50df6b6843f0104c8d38c98f596 Mon Sep 17 00:00:00 2001
From: zzz <zzz@mail.i2p>
Date: Thu, 21 Nov 2013 22:24:42 +0000
Subject: [PATCH] I2CP SessionConfig clarifications

---
 www.i2p2/pages/common_structures_spec.html |  5 +++-
 www.i2p2/pages/i2cp_spec.html              | 33 ++++++++++++++++------
 2 files changed, 28 insertions(+), 10 deletions(-)

diff --git a/www.i2p2/pages/common_structures_spec.html b/www.i2p2/pages/common_structures_spec.html
index 6e07d4a0..16445ed7 100644
--- a/www.i2p2/pages/common_structures_spec.html
+++ b/www.i2p2/pages/common_structures_spec.html
@@ -1,7 +1,7 @@
 {% extends "_layout.html" %}
 {% block title %}Common structure Specification{% endblock %}
 {% block content %}
-Updated June 2013, current as of router version 0.9.6
+Updated November 2013, current as of router version 0.9.9
 <h1>Data types Specification</h1>
 <p>
   This document describes some data types common to all I2P protocols, like
@@ -262,6 +262,9 @@ UTF-8 strings in a RouterInfo options mapping in a I2NP Database Store Message w
 Mappings contained in I2NP messages (i.e. in a RouterAddress or RouterInfo)
 must be sorted by key so that the signature will be invariant.
 <li>
+Mappings contained in an <a href="i2cp_spec.html#struct_SessionConfig">I2CP SessionConfig</a>
+must be sorted by key so that the signature will be invariant.
+<li>
 Key and value string length limits are 255 bytes (not characters) each, plus the length byte. Length byte may be 0.
 <li>
 Total length limit is 65535 bytes, plus the 2 byte size field, or 65537 total.
diff --git a/www.i2p2/pages/i2cp_spec.html b/www.i2p2/pages/i2cp_spec.html
index c887dcba..e976365a 100644
--- a/www.i2p2/pages/i2cp_spec.html
+++ b/www.i2p2/pages/i2cp_spec.html
@@ -234,11 +234,16 @@ DSA <a href="common_structures_spec#type_Signature">Signature</a> of the previou
 </li></ol>
 
 <h4>Notes</h4>
-<p>
+<ul><li>
 The options are specified on the
 <a href="i2cp.html#options">I2CP Overview page</a>.
-</p>
-
+</li><li>
+The <a href="common_structures_spec#type_Mapping">Mapping</a>
+must be sorted by key so that the signature will be validated correctly in the router.
+</li><li>
+The creation date must be within +/- 30 seconds of the current time when processed by
+the router, or the config will be rejected.
+</li></ul>
 
 
 
@@ -511,11 +516,16 @@ The router responds with a <a href="#msg_SessionStatus">Session Status Message</
 </li></ol>
 
 <h4>Notes</h4>
-<p>
-The second message sent by the client after sending the Get Date Message and receiving the Set Date Message response.
-If the Date in the Session Config is too far from the router's current time, the session will be rejected.
+<ul><li>
+This is the second message sent by the client. Previously the client sent a Get Date Message and received a Set Date Message response.
+</li><li>
+If the Date in the Session Config is too far (more than +/- 30 seconds) from the router's current time, the session will be rejected.
+</li><li>
 If there is already a session on the router for this Destination, the session will be rejected.
-</p>
+</li><li>
+The <a href="common_structures_spec#type_Mapping">Mapping</a> in the Session Config
+must be sorted by key so that the signature will be validated correctly in the router.
+</li></ul>
 
 
 
@@ -841,9 +851,14 @@ The router responds with a <a href="#msg_SessionStatus">Session Status Message</
 </li></ol>
 
 <h4>Notes</h4>
-<p>
+<ul><li>
 As of release 0.7.1.
-</p>
+</li><li>
+If the Date in the Session Config is too far (more than +/- 30 seconds) from the router's current time, the session will be rejected.
+</li><li>
+The <a href="common_structures_spec#type_Mapping">Mapping</a> in the Session Config
+must be sorted by key so that the signature will be validated correctly in the router.
+</li></ul>