findbugs all over

This commit is contained in:
zzz
2014-06-13 21:37:18 +00:00
parent ab44488e4c
commit 002d057c92
19 changed files with 50 additions and 25 deletions

View File

@ -117,7 +117,7 @@ class RequestLeaseSetMessageHandler extends HandlerImpl {
_context.random().nextBytes(dummy);
spk = new SigningPrivateKey(dummy);
}
session.getProducer().createLeaseSet(session, leaseSet, li.getSigningPrivateKey(), li.getPrivateKey());
session.getProducer().createLeaseSet(session, leaseSet, spk, li.getPrivateKey());
session.setLeaseSet(leaseSet);
} catch (DataFormatException dfe) {
session.propogateError("Error signing the leaseSet", dfe);

View File

@ -181,4 +181,9 @@ public class Destination extends KeysAndCert {
_cache.clear();
}
}
@Override
public boolean equals(Object o) {
return super.equals(o) && (o instanceof Destination);
}
}

View File

@ -29,4 +29,9 @@ public class RouterIdentity extends KeysAndCert {
public boolean isHidden() {
return (_certificate != null) && (_certificate.getCertificateType() == Certificate.CERTIFICATE_TYPE_HIDDEN);
}
@Override
public boolean equals(Object o) {
return super.equals(o) && (o instanceof LeaseSet);
}
}

View File

@ -203,7 +203,6 @@ public class SessionConfig extends DataStructureImpl {
_signature.writeBytes(out);
}
/* FIXME missing hashCode() method FIXME */
@Override
public boolean equals(Object object) {
if ((object != null) && (object instanceof SessionConfig)) {
@ -217,6 +216,11 @@ public class SessionConfig extends DataStructureImpl {
return false;
}
@Override
public int hashCode() {
return _signature != null ? _signature.hashCode() : 0;
}
@Override
public String toString() {
StringBuilder buf = new StringBuilder("[SessionConfig: ");

View File

@ -80,4 +80,9 @@ class LogRecord {
((_throwable == null && r._throwable == null) ||
(_throwable != null && r._throwable != null && _throwable.getClass() == r._throwable.getClass()));
}
@Override
public int hashCode() {
return _message != null ? _message.hashCode() : 0;
}
}

View File

@ -805,4 +805,10 @@ public class NativeBigInteger extends BigInteger {
// use linux as the default, don't throw exception
return "jbigi-linux-";
}
@Override
public boolean equals(Object o) {
// for findbugs
return super.equals(o);
}
}