echelon/i2p.i2p
1
0
Fork 0
forked from I2P_Developers/i2p.i2p
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Findbugs all over #2

Browse Source 
Mostly char encoding
Use StringWriter rather than OSW->BAOS->String
This commit is contained in:
zzz
2015-07-12 16:06:49 +00:00
parent 914cc120ad
commit 1f9bb046f5
25 changed files with 76 additions and 68 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
apps/routerconsole/java/src/net/i2p/router/web/ConfigKeyringHelper.java
View File

@ -1,20 +1,19 @@
package net.i2p.router.web;
import java.io.ByteArrayOutputStream;
import java.io.IOException;
import java.io.OutputStreamWriter;
import java.io.StringWriter;
public class ConfigKeyringHelper extends HelperBase {
public ConfigKeyringHelper() {}
public String getSummary() {
ByteArrayOutputStream baos = new ByteArrayOutputStream(4*1024);
StringWriter sw = new StringWriter(4*1024);
try {
_context.keyRing().renderStatusHTML(new OutputStreamWriter(baos));
_context.keyRing().renderStatusHTML(sw);
} catch (IOException ioe) {
ioe.printStackTrace();
}
return new String(baos.toByteArray());
return sw.toString();
}
}

9
apps/routerconsole/java/src/net/i2p/router/web/ConfigPeerHelper.java
View File

@ -1,20 +1,19 @@
package net.i2p.router.web;
import java.io.ByteArrayOutputStream;
import java.io.IOException;
import java.io.OutputStreamWriter;
import java.io.StringWriter;
public class ConfigPeerHelper extends HelperBase {
public ConfigPeerHelper() {}
public String getBlocklistSummary() {
ByteArrayOutputStream baos = new ByteArrayOutputStream(4*1024);
StringWriter sw = new StringWriter(4*1024);
try {
_context.blocklist().renderStatusHTML(new OutputStreamWriter(baos));
_context.blocklist().renderStatusHTML(sw);
} catch (IOException ioe) {
ioe.printStackTrace();
}
return new String(baos.toByteArray());
return sw.toString();
}
}

9
apps/routerconsole/java/src/net/i2p/router/web/JobQueueHelper.java
View File

@ -1,8 +1,7 @@
package net.i2p.router.web;
import java.io.ByteArrayOutputStream;
import java.io.IOException;
import java.io.OutputStreamWriter;
import java.io.StringWriter;
import java.io.Serializable;
import java.io.Writer;
import java.util.ArrayList;
@ -25,9 +24,9 @@ public class JobQueueHelper extends HelperBase {
renderStatusHTML(_out);
return "";
} else {
ByteArrayOutputStream baos = new ByteArrayOutputStream(32*1024);
renderStatusHTML(new OutputStreamWriter(baos));
return new String(baos.toByteArray());
StringWriter sw = new StringWriter(32*1024);
renderStatusHTML(sw);
return sw.toString();
}
} catch (IOException ioe) {
ioe.printStackTrace();

9
apps/routerconsole/java/src/net/i2p/router/web/TunnelHelper.java
View File

@ -1,8 +1,7 @@
package net.i2p.router.web;
import java.io.ByteArrayOutputStream;
import java.io.IOException;
import java.io.OutputStreamWriter;
import java.io.StringWriter;
public class TunnelHelper extends HelperBase {
@ -15,9 +14,9 @@ public class TunnelHelper extends HelperBase {
renderer.renderStatusHTML(_out);
return "";
} else {
ByteArrayOutputStream baos = new ByteArrayOutputStream(32*1024);
renderer.renderStatusHTML(new OutputStreamWriter(baos));
return new String(baos.toByteArray());
StringWriter sw = new StringWriter(32*1024);
renderer.renderStatusHTML(sw);
return sw.toString();
}
} catch (IOException ioe) {
ioe.printStackTrace();