Big findbugs cleanup

This commit is contained in:
zzz
2008-10-19 22:09:14 +00:00
parent 8a756a6e81
commit 20effe3a7f
77 changed files with 261 additions and 245 deletions

View File

@ -54,36 +54,36 @@ public class ConfigFile {
private boolean readConfigFile() {
FileInputStream fileInputStream = null;
boolean rv = true;
try {
fileInputStream = new FileInputStream(_configFile);
_properties.load(fileInputStream);
} catch (Exception e) {
return false;
rv = false;
}
try {
fileInputStream.close();
} catch (IOException e) {
// No worries.
}
return true;
return rv;
}
private boolean writeConfigFile() {
FileOutputStream fileOutputStream = null;
boolean rv = true;
try {
fileOutputStream = new FileOutputStream(_configFile);
_properties.store(fileOutputStream, null);
} catch (Exception e) {
return false;
rv = false;
}
try {
fileOutputStream.close();
} catch (IOException e) {
// No worries.
}
return true;
return rv;
}
}

View File

@ -85,8 +85,10 @@ public class UrlLauncher {
new File("browser.reg").delete();
} catch (Exception e) {
// Defaults to IE.
} finally {
if (bufferedReader != null)
try { bufferedReader.close(); } catch (IOException ioe) {}
}
if (_shellCommand.executeSilentAndWaitTimed(browserString + " " + url, 5))
return true;