echelon/i2p.i2p
1
0
Fork 0
forked from I2P_Developers/i2p.i2p
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

findbugs all over

Browse Source
This commit is contained in:
zzz
2014-10-07 14:59:49 +00:00
parent 8270a92a44
commit 28ad95f892
5 changed files with 9 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
apps/i2psnark/java/src/org/klomp/snark/web/Sorters.java
View File

@ -185,7 +185,6 @@ class Sorters {
private static int getStatus(Snark snark) { private static int getStatus(Snark snark) {
long remaining = snark.getRemainingLength(); long remaining = snark.getRemainingLength();
long needed = snark.getNeededLength();
if (snark.isStopped()) { if (snark.isStopped()) {
if (remaining < 0) if (remaining < 0)
return 0; return 0;

5
apps/susimail/src/src/org/mortbay/util/ByteArrayPool.java
View File

@ -15,6 +15,7 @@
package org.mortbay.util; package org.mortbay.util;
import java.util.concurrent.atomic.AtomicInteger;
/* ------------------------------------------------------------ */ /* ------------------------------------------------------------ */
/** Byte Array Pool /** Byte Array Pool
@ -29,7 +30,7 @@ public class ByteArrayPool
Integer.getInteger("org.mortbay.util.ByteArrayPool.pool_size",8).intValue(); Integer.getInteger("org.mortbay.util.ByteArrayPool.pool_size",8).intValue();
public static final ThreadLocal __pools=new BAThreadLocal(); public static final ThreadLocal __pools=new BAThreadLocal();
public static int __slot; public static final AtomicInteger __slot = new AtomicInteger();
/* ------------------------------------------------------------ */ /* ------------------------------------------------------------ */
/** Get a byte array from the pool of known size. /** Get a byte array from the pool of known size.
@ -94,7 +95,7 @@ public class ByteArrayPool
} }
// slot. // slot.
int s = __slot++; int s = __slot.getAndIncrement();
if (s<0)s=-s; if (s<0)s=-s;
pool[s%pool.length]=b; pool[s%pool.length]=b;
} }

2
core/java/src/net/i2p/client/DomainSocketFactory.java
View File

@ -16,7 +16,7 @@ import net.i2p.I2PAppContext;
* @since 0.9.14 * @since 0.9.14
*/ */
public class DomainSocketFactory { public class DomainSocketFactory {
public static String I2CP_SOCKET_ADDRESS = "net.i2p.client.i2cp"; public static final String I2CP_SOCKET_ADDRESS = "net.i2p.client.i2cp";
/** /**
* @throws UnsupportedOperationException always * @throws UnsupportedOperationException always

6
core/java/src/net/i2p/crypto/eddsa/math/ed25519/Ed25519FieldElement.java
View File

@ -846,7 +846,11 @@ public class Ed25519FieldElement extends FieldElement {
@Override @Override
public int hashCode() { public int hashCode() {
return t.hashCode(); // TODO should this be something else? int rv = 0;
for (int i = 0; i < 10; i++) {
rv ^= t[i];
}
return rv;
} }
@Override @Override

1
router/java/src/net/i2p/router/transport/udp/UDPPacketReader.java
View File

@ -569,7 +569,6 @@ class UDPPacketReader {
* @since 0.9.16 * @since 0.9.16
*/ */
public int highestReceived() { public int highestReceived() {
int count = fragmentCount();
for (int i = _bitfieldSize - 1; i >= 0; i--) { for (int i = _bitfieldSize - 1; i >= 0; i--) {
byte b = _message[_bitfieldStart + i]; byte b = _message[_bitfieldStart + i];
if ((b & 0x7f) == 0) if ((b & 0x7f) == 0)