echelon/i2p.i2p
1
0
Fork 0
forked from I2P_Developers/i2p.i2p
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

lint: don't catch Exception, catch RuntimeException or checked exception.

Browse Source 
omits SAM, BOB, reflection, commented-out code, and a few other places
This commit is contained in:
zzz
2015-11-12 18:49:13 +00:00
parent 37a4fcb469
commit 51c5da3f72
78 changed files with 235 additions and 136 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
apps/i2psnark/java/src/org/klomp/snark/SnarkManager.java
View File

@ -2051,7 +2051,7 @@ public class SnarkManager implements CompleteListener {
synchronized (_snarks) {
ok = monitorTorrents(dir);
}
} catch (Exception e) {
} catch (RuntimeException e) {
_log.error("Error in the DirectoryMonitor", e);
ok = false;
}
@ -2060,7 +2060,7 @@ public class SnarkManager implements CompleteListener {
try {
addMagnets();
doMagnets = false;
} catch (Exception e) {
} catch (RuntimeException e) {
_log.error("Error in the DirectoryMonitor", e);
}
if (!_snarks.isEmpty())
@ -2266,7 +2266,7 @@ public class SnarkManager implements CompleteListener {
// Snark.fatal() throws a RuntimeException
// don't let one bad torrent kill the whole loop
addTorrent(name, null, !shouldAutoStart());
} catch (Exception e) {
} catch (RuntimeException e) {
addMessage(_t("Error: Could not add the torrent {0}", name) + ": " + e);
_log.error("Unable to add the torrent " + name, e);
rv = false;
@ -2285,7 +2285,7 @@ public class SnarkManager implements CompleteListener {
// Snark.fatal() throws a RuntimeException
// don't let one bad torrent kill the whole loop
stopTorrent(name, true);
} catch (Exception e) {
} catch (RuntimeException e) {
// don't bother with message
}
}
@ -2467,7 +2467,7 @@ public class SnarkManager implements CompleteListener {
public void run() {
try {
run2();
} catch (Exception e) {
} catch (RuntimeException e) {
_log.error("Error starting", e);
}
}
@ -2595,7 +2595,7 @@ public class SnarkManager implements CompleteListener {
} else {
addMessageNoEscape(_t("Finished recheck of torrent {0}, unchanged", link));
}
} catch (Exception e) {
} catch (IOException e) {
_log.error("Error rechecking " + snark.getBaseName(), e);
addMessage(_t("Error checking the torrent {0}", snark.getBaseName()) + ": " + e);
}

4
apps/i2psnark/java/src/org/klomp/snark/Storage.java
View File

@ -748,7 +748,7 @@ public class Storage implements Closeable
}
rv = repl;
}
} catch (Exception ex) {
} catch (RuntimeException ex) {
ex.printStackTrace();
}
}
@ -1483,7 +1483,7 @@ public class Storage implements Closeable
break;
} // switch
} // while
} catch (Exception e) {
} catch (RuntimeException e) {
e.printStackTrace();
error = true;
}

2
apps/i2psnark/java/src/org/klomp/snark/dht/NodeInfo.java
View File

@ -225,7 +225,7 @@ class NodeInfo extends SimpleDataStructure {
NodeInfo ni = (NodeInfo) o;
// assume dest matches, ignore it
return this.hash.equals(ni.hash) && nID.equals(ni.nID) && port == ni.port;
} catch (Exception e) {
} catch (RuntimeException e) {
return false;
}
}