echelon/i2p.i2p
1
0
Fork 0
forked from I2P_Developers/i2p.i2p
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

more misc. findbugs

Browse Source
This commit is contained in:
zzz
2011-07-08 18:05:28 +00:00
parent 44f4e551b7
commit 56650ebfb4
6 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
apps/ministreaming/java/src/net/i2p/client/streaming/I2PSocketEepGet.java
View File

@ -163,7 +163,7 @@ public class I2PSocketEepGet extends EepGet {
protected String getRequest() throws IOException { protected String getRequest() throws IOException {
StringBuilder buf = new StringBuilder(2048); StringBuilder buf = new StringBuilder(2048);
URL url = new URL(_actualURL); URL url = new URL(_actualURL);
String host = url.getHost(); //String host = url.getHost();
String path = url.getPath(); String path = url.getPath();
String query = url.getQuery(); String query = url.getQuery();
if (query != null) if (query != null)

1
apps/routerconsole/java/src/net/i2p/router/web/NetDbRenderer.java
View File

@ -407,7 +407,6 @@ public class NetDbRenderer {
*/ */
private static int classifyTransports(RouterInfo info) { private static int classifyTransports(RouterInfo info) {
int rv = 0; int rv = 0;
String hash = info.getIdentity().getHash().toBase64();
for (RouterAddress addr : info.getAddresses()) { for (RouterAddress addr : info.getAddresses()) {
String style = addr.getTransportStyle(); String style = addr.getTransportStyle();
if (style.equals("NTCP")) { if (style.equals("NTCP")) {

3
apps/routerconsole/java/src/net/i2p/router/web/PluginUpdateChecker.java
View File

@ -128,7 +128,8 @@ public class PluginUpdateChecker extends UpdateHandler {
protected void update() { protected void update() {
updateStatus("<b>" + _("Checking for update of plugin {0}", _appName) + "</b>"); updateStatus("<b>" + _("Checking for update of plugin {0}", _appName) + "</b>");
// use the same settings as for updater // use the same settings as for updater
boolean shouldProxy = Boolean.valueOf(_context.getProperty(ConfigUpdateHandler.PROP_SHOULD_PROXY, ConfigUpdateHandler.DEFAULT_SHOULD_PROXY)).booleanValue(); // always proxy, or else FIXME
//boolean shouldProxy = Boolean.valueOf(_context.getProperty(ConfigUpdateHandler.PROP_SHOULD_PROXY, ConfigUpdateHandler.DEFAULT_SHOULD_PROXY)).booleanValue();
String proxyHost = _context.getProperty(ConfigUpdateHandler.PROP_PROXY_HOST, ConfigUpdateHandler.DEFAULT_PROXY_HOST); String proxyHost = _context.getProperty(ConfigUpdateHandler.PROP_PROXY_HOST, ConfigUpdateHandler.DEFAULT_PROXY_HOST);
int proxyPort = _context.getProperty(ConfigUpdateHandler.PROP_PROXY_PORT, ConfigUpdateHandler.DEFAULT_PROXY_PORT_INT); int proxyPort = _context.getProperty(ConfigUpdateHandler.PROP_PROXY_PORT, ConfigUpdateHandler.DEFAULT_PROXY_PORT_INT);
_baos.reset(); _baos.reset();

2
apps/susidns/src/java/src/i2p/susi/dns/SubscriptionsBean.java
View File

@ -130,8 +130,8 @@ public class SubscriptionsBean
if( lastSerial != null && serial != null && serial.compareTo( lastSerial ) == 0 ) { if( lastSerial != null && serial != null && serial.compareTo( lastSerial ) == 0 ) {
if (action.equals(_("Save"))) { if (action.equals(_("Save"))) {
save(); save();
String nonce = System.getProperty("addressbook.nonce");
/******* /*******
String nonce = System.getProperty("addressbook.nonce");
if (nonce != null) { if (nonce != null) {
// Yes this is a hack. // Yes this is a hack.
// No it doesn't work on a text-mode browser. // No it doesn't work on a text-mode browser.

2
core/java/src/gnu/crypto/prng/AsyncFortunaStandalone.java
View File

@ -156,7 +156,7 @@ public class AsyncFortunaStandalone extends FortunaStandalone implements Runnabl
} }
private void doFill(byte buf[]) { private void doFill(byte buf[]) {
long start = System.currentTimeMillis(); //long start = System.currentTimeMillis();
if (pool0Count >= MIN_POOL_SIZE if (pool0Count >= MIN_POOL_SIZE
&& System.currentTimeMillis() - lastReseed > 100) && System.currentTimeMillis() - lastReseed > 100)
{ {

1
core/java/src/net/i2p/time/Timestamper.java
View File

@ -316,7 +316,6 @@ public class Timestamper implements Runnable {
System.setProperty(PROP_DISABLED, "false"); System.setProperty(PROP_DISABLED, "false");
System.setProperty(PROP_QUERY_FREQUENCY, "30000"); System.setProperty(PROP_QUERY_FREQUENCY, "30000");
I2PAppContext ctx = I2PAppContext.getGlobalContext(); I2PAppContext ctx = I2PAppContext.getGlobalContext();
long now = ctx.clock().now();
for (int i = 0; i < 5*60*1000; i += 61*1000) { for (int i = 0; i < 5*60*1000; i += 61*1000) {
try { Thread.sleep(61*1000); } catch (InterruptedException ie) {} try { Thread.sleep(61*1000); } catch (InterruptedException ie) {}
} }