Console: Show correct icon for "Firewalled" network status

apps/routerconsole/java/src/net/i2p/router/web/SummaryBarRenderer.java

@@ -407,6 +407,9 @@ class SummaryBarRenderer {
             case HIDDEN:
                 buf.append("hidden");
                 break;
+            case FIREWALLED:
+                buf.append("firewalled");
+                break;
             case RUNNING:
                 buf.append("running");
                 break;

apps/routerconsole/java/src/net/i2p/router/web/SummaryHelper.java

@@ -132,6 +132,7 @@ public class SummaryHelper extends HelperBase {
     public enum NetworkState {
         HIDDEN,
         TESTING,
+        FIREWALLED,
         RUNNING,
         WARN,
         ERROR;
@@ -221,6 +222,7 @@ public class SummaryHelper extends HelperBase {
                 return new NetworkStateMessage(NetworkState.ERROR, _t("ERR-SymmetricNAT"));
 
             case REJECT_UNSOLICITED:
+                state = NetworkState.FIREWALLED;
             case IPV4_DISABLED_IPV6_FIREWALLED:
                 if (routerInfo.getTargetAddress("NTCP") != null)
                     return new NetworkStateMessage(NetworkState.WARN, _t("WARN-Firewalled with Inbound TCP Enabled"));
@@ -231,7 +233,7 @@ public class SummaryHelper extends HelperBase {
                     return new NetworkStateMessage(NetworkState.WARN, _t("WARN-Firewalled and Floodfill"));
                 //if (_context.router().getRouterInfo().getCapabilities().indexOf('O') >= 0)
                 //    return new NetworkStateMessage(NetworkState.WARN, _t("WARN-Firewalled and Fast"));
-                return new NetworkStateMessage(NetworkState.RUNNING, _t(status.toStatusString()));
+                return new NetworkStateMessage(state, _t(status.toStatusString()));
 
             case DISCONNECTED:
                 return new NetworkStateMessage(NetworkState.TESTING, _t("Disconnected - check network connection"));

history.txt

@@ -15,6 +15,7 @@
    - /tunnels:
      - Tag "Local" for translation (and convert to lowercase in CSS)
      - Arabic: ensure our tunnel tables display correctly
+   - Show correct icon for "Firewalled" network status
  * I2PSnark:
    - Fix unclosed <label>
    - Standalone: