diff --git a/apps/routerconsole/java/src/net/i2p/router/web/ConfigClientsHandler.java b/apps/routerconsole/java/src/net/i2p/router/web/ConfigClientsHandler.java index 13b0800018..b216ed3ff6 100644 --- a/apps/routerconsole/java/src/net/i2p/router/web/ConfigClientsHandler.java +++ b/apps/routerconsole/java/src/net/i2p/router/web/ConfigClientsHandler.java @@ -244,7 +244,7 @@ public class ConfigClientsHandler extends FormHandler { // edit of an existing entry if (_context.getBooleanProperty(ConfigClientsHelper.PROP_ENABLE_CLIENT_CHANGE) || isAdvanced()) { - String desc = getJettyString("desc" + cur); + String desc = getJettyString("nofilter_desc" + cur); if (desc != null) { int spc = desc.indexOf(" "); String clss = desc; @@ -255,7 +255,7 @@ public class ConfigClientsHandler extends FormHandler { } ca.className = clss; ca.args = args; - ca.clientName = getJettyString("name" + cur); + ca.clientName = getJettyString("nofilter_name" + cur); } } } @@ -264,7 +264,7 @@ public class ConfigClientsHandler extends FormHandler { if (_context.getBooleanProperty(ConfigClientsHelper.PROP_ENABLE_CLIENT_CHANGE) || isAdvanced()) { int newClient = clients.size(); - String newDesc = getJettyString("desc" + newClient); + String newDesc = getJettyString("nofilter_desc" + newClient); if (newDesc != null && newDesc.trim().length() > 0) { // new entry int spc = newDesc.indexOf(" "); @@ -274,10 +274,10 @@ public class ConfigClientsHandler extends FormHandler { clss = newDesc.substring(0, spc); args = newDesc.substring(spc + 1); } - String name = getJettyString("name" + newClient); + String name = getJettyString("nofilter_name" + newClient); if (name == null || name.trim().length() <= 0) name = "new client"; ClientAppConfig ca = new ClientAppConfig(clss, name, args, 2*60*1000, - _settings.get(newClient + ".enabled") != null); + _settings.get(newClient + ".enabled") == null); // true for disabled clients.add(ca); addFormNotice(_t("New client added") + ": " + name + " (" + clss + ")."); } diff --git a/apps/routerconsole/java/src/net/i2p/router/web/ConfigClientsHelper.java b/apps/routerconsole/java/src/net/i2p/router/web/ConfigClientsHelper.java index c0e4df1582..86d0648537 100644 --- a/apps/routerconsole/java/src/net/i2p/router/web/ConfigClientsHelper.java +++ b/apps/routerconsole/java/src/net/i2p/router/web/ConfigClientsHelper.java @@ -322,23 +322,24 @@ public class ConfigClientsHelper extends HelperBase { boolean enabled, boolean ro, boolean preventDisable, String desc, boolean edit, boolean showEditButton, boolean showUpdateButton, boolean showStopButton, boolean showDeleteButton, boolean showStartButton) { - String escapeddesc = DataHelper.escapeHTML(desc); + String escapedName = DataHelper.escapeHTML(name); + String escapedDesc = DataHelper.escapeHTML(desc); buf.append(""); if (urlify && enabled) { String link = "/"; if (! RouterConsoleRunner.ROUTERCONSOLE.equals(name)) - link += name + "/"; - buf.append("").append(_t(name)).append(""); + link += escapedName + "/"; + buf.append("").append(_t(escapedName)).append(""); } else if (edit && !ro) { - buf.append(" 0) - buf.append(_t(name)); + buf.append(_t(escapedName)); buf.append("\" >"); } else { if (name.length() > 0) - buf.append(_t(name)); + buf.append(_t(escapedName)); } - buf.append("") .append(_t("Delete")).append(" ").append(index).append(""); } buf.append(""); if (edit && !ro) { - buf.append(""); } else { - buf.append(desc); + buf.append(escapedDesc); } buf.append("\n"); } diff --git a/history.txt b/history.txt index 4084b5abbe..3debcdab40 100644 --- a/history.txt +++ b/history.txt @@ -1,11 +1,16 @@ +2015-11-12 zzz + * Console /configclients: + = Fix filtering and escaping + - Fix autostart setting on new client, was inverted + 2015-11-11 zzz * i2psnark: - - Change log level to hide socket closed error at tunnel shutdown + - Change log level to hide socket closed error at tunnel shutdown (ticket #1687) - Increase max pieces * Timers: State fix 4th try (tickets #1694, #1705) 2015-11-05 zzz - * I2CP: Fix additional connections getting rejected during tunnel open (ticket #1650) + * I2CP: Fix additional connections getting rejected during tunnel open (tickets #1650, #1698) * Streaming: Split blacklist into one for EC and one for Ed 2015-11-04 zzz diff --git a/router/java/src/net/i2p/router/RouterVersion.java b/router/java/src/net/i2p/router/RouterVersion.java index 3c775e75ad..0e04b1445c 100644 --- a/router/java/src/net/i2p/router/RouterVersion.java +++ b/router/java/src/net/i2p/router/RouterVersion.java @@ -18,7 +18,7 @@ public class RouterVersion { /** deprecated */ public final static String ID = "Monotone"; public final static String VERSION = CoreVersion.VERSION; - public final static long BUILD = 25; + public final static long BUILD = 26; /** for example "-test" */ public final static String EXTRA = "-rc";