echelon/i2p.i2p
1
0
Fork 0
forked from I2P_Developers/i2p.i2p
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Cleanups: Close resources via try-finally

Browse Source 
We can't use try-with-resources until we bump the minimum-supported Android
version for the client library to API 19.
This commit is contained in:
str4d
2017-12-09 01:02:17 +00:00
parent fe5e4a2c7a
commit a67ea4b2f2
14 changed files with 81 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
apps/systray/java/src/net/i2p/apps/systray/UrlLauncher.java
View File

@ -136,13 +136,15 @@ public class UrlLauncher implements ClientApp {
long done = System.currentTimeMillis() + MAX_WAIT_TIME;
for (int i = 0; i < MAX_TRIES; i++) {
try {
Socket test = new Socket();
// this will usually fail right away if it's going to fail since it's local
test.connect(sa, WAIT_TIME);
// it worked
Socket test = null;
try {
test.close();
} catch (IOException ioe) {}
test = new Socket();
// this will usually fail right away if it's going to fail since it's local
test.connect(sa, WAIT_TIME);
// it worked
} finally {
if (test != null) try { test.close(); } catch (IOException ioe) {}
}
// Jetty 6 seems to start the Connector before the
// webapp is completely ready
try {