Streaming: Fix race NPE (thx echelon)

apps/streaming/java/src/net/i2p/client/streaming/Connection.java

@@ -548,9 +548,11 @@ class Connection {
     
     void disconnectComplete() {
         _connected = false;
-        if (_socket != null)
+        I2PSocketFull s = _socket;
-            _socket.destroy();
+        if (s != null) {
-        _socket = null;
+            s.destroy2();
+            _socket = null;
+        }
         if (_outputStream != null)
             _outputStream.destroy();
         if (_receiver != null)

apps/streaming/java/src/net/i2p/client/streaming/I2PSocketFull.java

@@ -131,12 +131,21 @@ class I2PSocketFull implements I2PSocket {
     
     void destroy() { 
         Connection c = _connection;
-        _connection = null; 
+        destroy2();
-        _listener = null;
         if (c != null)
             c.disconnectComplete();
     }
     
+    /**
+     *  Call from Connection.disconnectComplete()
+     *  instead of destroy() so we don't loop
+     *  @since 0.8.13
+     */
+    void destroy2() { 
+        _connection = null; 
+        _listener = null;
+    }
+    
     /**
      * The remote port.
      * @return the port or 0 if unknown

history.txt

@@ -1,3 +1,6 @@
+2012-02-20 zzz
+  * Streaming: Fix race NPE (thx echelon)
+
 2012-02-17 zzz
   * i2psnark: Escape fixes
   * netdb.jsp: Fix debug median calculation

router/java/src/net/i2p/router/RouterVersion.java

@@ -18,7 +18,7 @@ public class RouterVersion {
     /** deprecated */
     public final static String ID = "Monotone";
     public final static String VERSION = CoreVersion.VERSION;
-    public final static long BUILD = 14;
+    public final static long BUILD = 15;
 
     /** for example "-test" */
     public final static String EXTRA = "-rc";