Linting dep-ann: Added @Deprecated annotations in BOB and i2p_sdk

apps/BOB/src/net/i2p/BOB/BOB.java

@@ -143,6 +143,7 @@ public class BOB implements Runnable, ClientApp {
 	 * Stop BOB gracefully
 	 * @deprecated unused
 	 */
+	@Deprecated
 	public synchronized static void stop() {
 		if (_bob != null)
 			_bob.shutdown(null);

apps/BOB/src/net/i2p/BOB/UDPIOthread.java

@@ -36,6 +36,7 @@ import net.i2p.util.Log;
  * @author sponge
  * @deprecated incomplete, unused
  */
+@Deprecated
 public class UDPIOthread implements I2PSessionListener, Runnable {
 
 	private final NamedDB info;

core/java/src/net/i2p/I2PAppContext.java

@@ -744,6 +744,7 @@ public class I2PAppContext {
     }
 
     /** @deprecated used only by syndie */
+    @Deprecated
     public HMAC256Generator hmac256() {
         if (!_hmac256Initialized)
             initializeHMAC256();
@@ -751,6 +752,7 @@ public class I2PAppContext {
     }
 
     /** @deprecated used only by syndie */
+    @Deprecated
     private void initializeHMAC256() {
         synchronized (_lock10) {
             if (_hmac256 == null) {
@@ -941,6 +943,7 @@ public class I2PAppContext {
      * @since 0.9 to replace static instance in the class
      * @deprecated in 0.9.20, use simpleTimer2()
      */
+    @Deprecated
     @SuppressWarnings("deprecation")
     public SimpleScheduler simpleScheduler() {
         if (!_simpleSchedulerInitialized)
@@ -951,6 +954,7 @@ public class I2PAppContext {
     /**
      * @deprecated in 0.9.20
      */
+    @Deprecated
     private void initializeSimpleScheduler() {
         synchronized (_lock18) {
             if (_simpleScheduler == null)
@@ -964,6 +968,7 @@ public class I2PAppContext {
      * @since 0.9 to replace static instance in the class
      * @deprecated use SimpleTimer2
      */
+    @Deprecated
     public SimpleTimer simpleTimer() {
         if (!_simpleTimerInitialized)
             initializeSimpleTimer();
@@ -973,6 +978,7 @@ public class I2PAppContext {
     /**
      * @deprecated use SimpleTimer2
      */
+    @Deprecated
     private void initializeSimpleTimer() {
         synchronized (_lock19) {
             if (_simpleTimer == null)

core/java/src/net/i2p/client/I2PSimpleClient.java

@@ -27,6 +27,7 @@ public class I2PSimpleClient implements I2PClient {
      *  @deprecated Don't do this
      *  @throws UnsupportedOperationException always
      */
+    @Deprecated
     public Destination createDestination(OutputStream destKeyStream) throws I2PException, IOException {
         throw new UnsupportedOperationException();
     }
@@ -36,6 +37,7 @@ public class I2PSimpleClient implements I2PClient {
      *  @throws UnsupportedOperationException always
      *  @since 0.9.12
      */
+    @Deprecated
     public Destination createDestination(OutputStream destKeyStream, SigType type) throws I2PException, IOException {
         throw new UnsupportedOperationException();
     }
@@ -44,6 +46,7 @@ public class I2PSimpleClient implements I2PClient {
      *  @deprecated Don't do this
      *  @throws UnsupportedOperationException always
      */
+    @Deprecated
     public Destination createDestination(OutputStream destKeyStream, Certificate cert) throws I2PException, IOException {
         throw new UnsupportedOperationException();
     }

core/java/src/net/i2p/client/naming/EepGetAndAddNamingService.java

@@ -35,6 +35,7 @@ import net.i2p.data.Destination;
  * @deprecated use HostsTxtNamingService.put()
  * @since 0.7.9
  */
+@Deprecated
 public class EepGetAndAddNamingService extends EepGetNamingService {
 
     /** default hosts.txt filename */

core/java/src/net/i2p/crypto/AESEngine.java

@@ -72,6 +72,7 @@ public class AESEngine {
      * @return null on error
      * @deprecated unused
      */
+    @Deprecated
     public byte[] safeEncrypt(byte payload[], SessionKey sessionKey, byte iv[], int paddedSize) {
         if ((iv == null) || (payload == null) || (sessionKey == null) || (iv.length != 16)) return null;
 
@@ -103,6 +104,7 @@ public class AESEngine {
      * @return null on error
      * @deprecated unused
      */
+    @Deprecated
     public byte[] safeDecrypt(byte payload[], SessionKey sessionKey, byte iv[]) {
         if ((iv == null) || (payload == null) || (sessionKey == null) || (iv.length != 16)) return null;
 

core/java/src/net/i2p/crypto/CryptixAESKeyCache.java

@@ -26,6 +26,7 @@ public final class CryptixAESKeyCache {
     /*
      * @deprecated unused, keys are now cached in the SessionKey objects
      */
+    @Deprecated
     public CryptixAESKeyCache() {
         _availableKeys = new LinkedBlockingQueue<KeyCacheEntry>(MAX_KEYS);
     }
@@ -35,6 +36,7 @@ public final class CryptixAESKeyCache {
      *
      * @deprecated unused, keys are now cached in the SessionKey objects
      */
+    @Deprecated
     public final KeyCacheEntry acquireKey() {
         KeyCacheEntry rv = _availableKeys.poll();
         if (rv != null)
@@ -47,6 +49,7 @@ public final class CryptixAESKeyCache {
      *
      * @deprecated unused, keys are now cached in the SessionKey objects
      */
+    @Deprecated
     public final void releaseKey(KeyCacheEntry key) {
         _availableKeys.offer(key);
     }

core/java/src/net/i2p/crypto/HMACGenerator.java

@@ -58,6 +58,7 @@ public class HMACGenerator {
      * @return the first 16 bytes contain the HMAC, the last 16 bytes are zero
      * @deprecated unused (not even by Syndie)
      */
+    @Deprecated
     public Hash calculate(SessionKey key, byte data[]) {
         if ((key == null) || (key.getData() == null) || (data == null))
             throw new NullPointerException("Null arguments for HMAC");

core/java/src/net/i2p/data/LeaseSet.java

@@ -141,6 +141,7 @@ public class LeaseSet extends DatabaseEntry {
      *  The revocation key.
      *  @deprecated unused
      */
+    @Deprecated
     public SigningPublicKey getSigningKey() {
         return _signingKey;
     }
@@ -262,6 +263,7 @@ public class LeaseSet extends DatabaseEntry {
      * @deprecated revocation unused
      * @return true only if the signature matches
      */
+    @Deprecated
     public boolean verifySignature(SigningPublicKey signingKey) {
         if (super.verifySignature())
             return true;

core/java/src/net/i2p/data/Signature.java

@@ -35,6 +35,7 @@ public class Signature extends SimpleDataStructure {
      * all zeros
      * @deprecated to be removed
      */
+    @Deprecated
     public final static byte[] FAKE_SIGNATURE = new byte[SIGNATURE_BYTES];
 
     private final SigType _type;

core/java/src/net/i2p/data/i2cp/I2CPMessageReader.java

@@ -71,6 +71,7 @@ public class I2CPMessageReader {
      * Have the already started reader pause its reading indefinitely
      * @deprecated unused
      */
+    @Deprecated
     public void pauseReading() {
         _reader.pauseRunner();
     }
@@ -79,6 +80,7 @@ public class I2CPMessageReader {
      * Resume reading after a pause
      * @deprecated unused
      */
+    @Deprecated
     public void resumeReading() {
         _reader.resumeRunner();
     }

core/java/src/net/i2p/data/i2cp/RequestLeaseSetMessage.java

@@ -74,6 +74,7 @@ public class RequestLeaseSetMessage extends I2CPMessageImpl {
     }
 
     /** @deprecated unused - presumably he meant remove? */
+    @Deprecated
     public void remoteEndpoint(int endpoint) {
         if ((endpoint >= 0) && (endpoint < _endpoints.size())) _endpoints.remove(endpoint);
     }

core/java/src/net/i2p/internal/PoisonI2CPMessage.java

@@ -23,6 +23,7 @@ public class PoisonI2CPMessage extends I2CPMessageImpl {
      *  @deprecated don't do this
      *  @throws I2CPMessageException always
      */
+    @Deprecated
     protected void doReadMessage(InputStream in, int size) throws I2CPMessageException {
         throw new I2CPMessageException("Don't do this");
     }
@@ -31,6 +32,7 @@ public class PoisonI2CPMessage extends I2CPMessageImpl {
      *  @deprecated don't do this
      *  @throws I2CPMessageException always
      */
+    @Deprecated
     protected byte[] doWriteMessage() throws I2CPMessageException {
         throw new I2CPMessageException("Don't do this");
     }

core/java/src/net/i2p/stat/Frequency.java

@@ -35,6 +35,7 @@ public class Frequency {
      * when did the last event occur?
      * @deprecated unused
      */
+    @Deprecated
     public synchronized long getLastEvent() {
             return _lastEvent;
     }
@@ -53,6 +54,7 @@ public class Frequency {
      * @return milliseconds; returns period + 1 if no events in previous period
      * @deprecated unused
      */
+    @Deprecated
     public synchronized double getMinAverageInterval() {
             return _minAverageInterval;
     }

core/java/src/net/i2p/util/CachingByteArrayOutputStream.java

@@ -13,6 +13,7 @@ import net.i2p.data.ByteArray;
  * 
  * @deprecated unused
  */
+@Deprecated
 public class CachingByteArrayOutputStream extends ByteArrayOutputStream {
     private ByteCache _cache;
     private ByteArray _buf;

core/java/src/net/i2p/util/InternalServerSocket.java

@@ -130,56 +130,67 @@ public class InternalServerSocket extends ServerSocket {
 
     // everything below here unsupported
     /** @deprecated unsupported */
+    @Deprecated
     @Override
     public void bind(SocketAddress endpoint) {
         throw new IllegalArgumentException("unsupported");
     }
     /** @deprecated unsupported */
+    @Deprecated
     @Override
     public void bind(SocketAddress endpoint, int backlog) {
         throw new IllegalArgumentException("unsupported");
     }
     /** @deprecated unsupported */
+    @Deprecated
     @Override
     public ServerSocketChannel getChannel() {
         throw new IllegalArgumentException("unsupported");
     }
     /** @deprecated unsupported */
+    @Deprecated
     @Override
     public InetAddress getInetAddress() {
         throw new IllegalArgumentException("unsupported");
     }
     /** @deprecated unsupported */
+    @Deprecated
     @Override
     public SocketAddress getLocalSocketAddress() {
         throw new IllegalArgumentException("unsupported");
     }
     /** @deprecated unsupported */
+    @Deprecated
     @Override
     public int getReceiveBufferSize() {
         throw new IllegalArgumentException("unsupported");
     }
     /** @deprecated unsupported */
+    @Deprecated
     @Override
     public boolean getReuseAddress() {
         throw new IllegalArgumentException("unsupported");
     }
     /** @deprecated unsupported */
+    @Deprecated
     @Override
     public boolean isBound() {
         throw new IllegalArgumentException("unsupported");
     }
     /** @deprecated unsupported */
+    @Deprecated
     @Override
     public boolean isClosed() {
         throw new IllegalArgumentException("unsupported");
     }
     /** @deprecated unsupported */
+    @Deprecated
     @Override
     public void setReceiveBufferSize(int size) {
         throw new IllegalArgumentException("unsupported");
     }
     /** @deprecated unsupported */
+    @Deprecated
     @Override
     public void setReuseAddress(boolean on) {
         throw new IllegalArgumentException("unsupported");

core/java/src/net/i2p/util/InternalSocket.java

@@ -105,166 +105,199 @@ public class InternalSocket extends Socket {
 
     // everything below here unsupported
     /** @deprecated unsupported */
+    @Deprecated
     @Override
     public void bind(SocketAddress endpoint) {
         throw new UnsupportedOperationException();
     }
     /** @deprecated unsupported */
+    @Deprecated
     @Override
     public void connect(SocketAddress endpoint) {
         throw new UnsupportedOperationException();
     }
     /** @deprecated unsupported */
+    @Deprecated
     @Override
     public void connect(SocketAddress endpoint, int timeout) {
         throw new UnsupportedOperationException();
     }
     /** @deprecated unsupported */
+    @Deprecated
     @Override
     public SocketChannel getChannel() {
         throw new UnsupportedOperationException();
     }
     /** @deprecated unsupported */
+    @Deprecated
     @Override
     public InetAddress getInetAddress() {
         throw new UnsupportedOperationException();
     }
     /** @deprecated unsupported */
+    @Deprecated
     @Override
     public boolean getKeepAlive() {
         throw new UnsupportedOperationException();
     }
     /** @deprecated unsupported */
+    @Deprecated
     @Override
     public InetAddress getLocalAddress() {
         throw new UnsupportedOperationException();
     }
     /** @deprecated unsupported */
+    @Deprecated
     @Override
     public int getLocalPort() {
         throw new UnsupportedOperationException();
     }
     /** @deprecated unsupported */
+    @Deprecated
     @Override
     public SocketAddress getLocalSocketAddress() {
         throw new UnsupportedOperationException();
     }
     /** @deprecated unsupported */
+    @Deprecated
     @Override
     public boolean getOOBInline() {
         throw new UnsupportedOperationException();
     }
     /** @deprecated unsupported */
+    @Deprecated
     @Override
     public int getPort() {
         throw new UnsupportedOperationException();
     }
     /** @deprecated unsupported */
+    @Deprecated
     @Override
     public int getReceiveBufferSize() {
         throw new UnsupportedOperationException();
     }
     /** @deprecated unsupported */
+    @Deprecated
     @Override
     public SocketAddress getRemoteSocketAddress() {
         throw new UnsupportedOperationException();
     }
     /** @deprecated unsupported */
+    @Deprecated
     @Override
     public boolean getReuseAddress() {
         throw new UnsupportedOperationException();
     }
     /** @deprecated unsupported */
+    @Deprecated
     @Override
     public int getSendBufferSize() {
         throw new UnsupportedOperationException();
     }
     /** @deprecated unsupported */
+    @Deprecated
     @Override
     public int getSoLinger() {
         throw new UnsupportedOperationException();
     }
     /** @deprecated unsupported */
+    @Deprecated
     @Override
     public boolean getTcpNoDelay() {
         throw new UnsupportedOperationException();
     }
     /** @deprecated unsupported */
+    @Deprecated
     @Override
     public int getTrafficClass() {
         throw new UnsupportedOperationException();
     }
     /** @deprecated unsupported */
+    @Deprecated
     @Override
     public boolean isBound() {
         throw new UnsupportedOperationException();
     }
     /** @deprecated unsupported */
+    @Deprecated
     @Override
     public boolean isConnected() {
         throw new UnsupportedOperationException();
     }
     /** @deprecated unsupported */
+    @Deprecated
     @Override
     public boolean isInputShutdown() {
         throw new UnsupportedOperationException();
     }
     /** @deprecated unsupported */
+    @Deprecated
     @Override
     public boolean isOutputShutdown() {
         throw new UnsupportedOperationException();
     }
     /** @deprecated unsupported */
+    @Deprecated
     @Override
     public void sendUrgentData(int data) {
         throw new UnsupportedOperationException();
     }
     /** @deprecated unsupported */
+    @Deprecated
     @Override
     public void setKeepAlive(boolean on) {
         throw new UnsupportedOperationException();
     }
     /** @deprecated unsupported */
+    @Deprecated
     @Override
     public void setOOBInline(boolean on) {
         throw new UnsupportedOperationException();
     }
     /** @deprecated unsupported */
+    @Deprecated
     @Override
     public void setReceiveBufferSize(int size) {
         throw new UnsupportedOperationException();
     }
     /** @deprecated unsupported */
+    @Deprecated
     @Override
     public void setReuseAddress(boolean on) {
         throw new UnsupportedOperationException();
     }
     /** @deprecated unsupported */
+    @Deprecated
     @Override
     public void setSendBufferSize(int size) {
         throw new UnsupportedOperationException();
     }
     /** @deprecated unsupported */
+    @Deprecated
     @Override
     public void setSoLinger(boolean on, int linger) {
         throw new UnsupportedOperationException();
     }
     /** @deprecated unsupported */
+    @Deprecated
     @Override
     public void setTcpNoDelay(boolean on) {
         throw new UnsupportedOperationException();
     }
     /** @deprecated unsupported */
+    @Deprecated
     @Override
     public void setTrafficClass(int cize) {
         throw new UnsupportedOperationException();
     }
     /** @deprecated unsupported */
+    @Deprecated
     @Override
     public void shutdownInput() {
         throw new UnsupportedOperationException();
     }
     /** @deprecated unsupported */
+    @Deprecated
     @Override
     public void shutdownOutput() {
         throw new UnsupportedOperationException();

core/java/src/net/i2p/util/LogManager.java

@@ -210,6 +210,7 @@ public class LogManager implements Flushable {
     public LogConsoleBuffer getBuffer() { return _consoleBuffer; }
         
     /** @deprecated unused */
+    @Deprecated
     public void setDisplayOnScreen(boolean yes) {
         _displayOnScreen = yes;
     }
@@ -223,6 +224,7 @@ public class LogManager implements Flushable {
     }
 
     /** @deprecated unused */
+    @Deprecated
     public void setDisplayOnScreenLevel(int level) {
         _onScreenLimit = level;
     }
@@ -232,6 +234,7 @@ public class LogManager implements Flushable {
     }
 
     /** @deprecated unused */
+    @Deprecated
     public void setConsoleBufferSize(int numRecords) {
         _consoleBufferSize = numRecords;
     }

core/java/src/net/i2p/util/ShellCommand.java

@@ -190,6 +190,7 @@ public class ShellCommand {
      * 
      * @param shellCommand The command for the shell to execute.
      */
+    @Deprecated
     public void execute(String shellCommand) {
         execute(shellCommand, NO_CONSUME_OUTPUT, NO_WAIT_FOR_EXIT_STATUS);
     }
@@ -211,6 +212,7 @@ public class ShellCommand {
      *                      returns an exit status of 0 (indicating success),
      *                      else <code>false</code>.
      */
+    @Deprecated
     public boolean executeAndWait(String shellCommand) {
         return execute(shellCommand, NO_CONSUME_OUTPUT, WAIT_FOR_EXIT_STATUS);
     }
@@ -236,6 +238,7 @@ public class ShellCommand {
      *                      returns an exit status of 0 (indicating success),
      *                      else <code>false</code>.
      */
+    @Deprecated
     public boolean executeAndWaitTimed(String shellCommand, int seconds) {
         Result result = new Result();
         Thread commandThread = new CommandThread(shellCommand, NO_CONSUME_OUTPUT, result);
@@ -263,6 +266,7 @@ public class ShellCommand {
      * @param  shellCommand The command for the shell to execute.
      * @throws IOException
      */
+    @Deprecated
     public void executeSilent(String shellCommand) throws IOException {
         Runtime.getRuntime().exec(shellCommand, null);
     }
@@ -365,16 +369,19 @@ public class ShellCommand {
     }
 
     /** @deprecated unused */
+    @Deprecated
     public InputStream getErrorStream() {
         return _errorStream;
     }
 
     /** @deprecated unused */
+    @Deprecated
     public InputStream getInputStream() {
         return _inputStream;
     }
 
     /** @deprecated unused */
+    @Deprecated
     public OutputStream getOutputStream() {
         return _outputStream;
     }

core/java/src/net/i2p/util/SimpleScheduler.java

@@ -28,12 +28,14 @@ import net.i2p.I2PAppContext;
  *
  * @author zzz
  */
+@Deprecated
 public class SimpleScheduler {
 
     /**
      *  If you have a context, use context.simpleScheduler() instead
      *  @deprecated in 0.9.20, replaced by SimpleTimer2
      */
+    @Deprecated
     public static SimpleScheduler getInstance() {
         return I2PAppContext.getGlobalContext().simpleScheduler();
     }
@@ -51,6 +53,7 @@ public class SimpleScheduler {
      *  Others should use context.simpleTimer() instead
      *  @deprecated in 0.9.20, replaced by SimpleTimer2
      */
+    @Deprecated
     public SimpleScheduler(I2PAppContext context) {
         this(context, "SimpleScheduler");
     }
@@ -60,6 +63,7 @@ public class SimpleScheduler {
      *  Others should use context.simpleTimer() instead
      *  @deprecated in 0.9.20, replaced by SimpleTimer2
      */
+    @Deprecated
     private SimpleScheduler(I2PAppContext context, String name) {
         _log = context.logManager().getLog(SimpleScheduler.class);
         _name = name;

core/java/src/net/i2p/util/SimpleTimer.java

@@ -22,6 +22,7 @@ public class SimpleTimer {
      *  If you have a context, use context.simpleTimer() instead
      *  @deprecated use SimpleTimer2
      */
+	@Deprecated
     public static SimpleTimer getInstance() {
         return I2PAppContext.getGlobalContext().simpleTimer();
     }
@@ -41,6 +42,7 @@ public class SimpleTimer {
      *  Others should use context.simpleTimer() instead
      *  @deprecated use SimpleTimer2
      */
+    @Deprecated
     public SimpleTimer(I2PAppContext context) {
         this(context, "SimpleTimer");
     }
@@ -50,6 +52,7 @@ public class SimpleTimer {
      *  Others should use context.simpleTimer() instead
      *  @deprecated use SimpleTimer2
      */
+    @Deprecated
     private SimpleTimer(I2PAppContext context, String name) {
         runn = new SimpleStore(true);
         _log = context.logManager().getLog(SimpleTimer.class);

core/java/src/net/metanotion/util/skiplist/SkipList.java

@@ -139,6 +139,7 @@ public class SkipList implements Flushable {
 	 * dumps all the skip levels
 	 * @deprecated goes to System.out
 	 */
+	@Deprecated
 	public void printSL() {
 		System.out.println("List size " + size);
 		System.out.println(stack.printAll());

core/java/src/org/bouncycastle/oldcrypto/macs/I2PHMac.java

@@ -70,6 +70,7 @@ implements Mac
      *  Standard HMAC, size == digest size.
      *  @deprecated Use javax.crypto.Mac
      */
+    @Deprecated
     public I2PHMac(MessageDigest digest) {
         this(digest, digest.getDigestLength()); 
     }