From cad3c46ea62ec8e8c04d8b73414bea5e7ddb9ada Mon Sep 17 00:00:00 2001
From: zzz <zzz@mail.i2p>
Date: Tue, 3 Dec 2019 15:43:44 +0000
Subject: [PATCH] OCMOSJ: Cancel timeout job on reply JobQueue: Improve
 removeJob()

---
 history.txt                                          | 11 +++++++++++
 router/java/src/net/i2p/router/JobQueue.java         |  6 ++++--
 router/java/src/net/i2p/router/RouterVersion.java    |  2 +-
 .../message/OutboundClientMessageOneShotJob.java     | 12 ++++++++----
 4 files changed, 24 insertions(+), 7 deletions(-)

diff --git a/history.txt b/history.txt
index b85a63ae5d..a20d9cb131 100644
--- a/history.txt
+++ b/history.txt
@@ -1,3 +1,14 @@
+2019-12-03 zzz
+ * NDT: Numerous fixes (ticket #2672)
+ * OCMOSJ: Cancel timeout job on reply
+
+2019-12-02 zzz
+ * Console:
+   - Move restart status up in summary bar
+   - Process restart status first regardless of display order
+ * NDT: Prevent NPE on JSON parse of bad/empty input (ticket #2672)
+ * Update manager: Notify GeoIP type and file version
+
 * 2019-12-01 0.9.44 released
 
 2019-11-30 zzz
diff --git a/router/java/src/net/i2p/router/JobQueue.java b/router/java/src/net/i2p/router/JobQueue.java
index 22326f1c5c..3f0f9a5b7b 100644
--- a/router/java/src/net/i2p/router/JobQueue.java
+++ b/router/java/src/net/i2p/router/JobQueue.java
@@ -240,8 +240,10 @@ public class JobQueue {
     
     public void removeJob(Job job) {
         synchronized (_jobLock) {
-            _readyJobs.remove(job);
-            _timedJobs.remove(job);
+            boolean removed = _timedJobs.remove(job);
+            // linear search, do this last
+            if (!removed)
+                _readyJobs.remove(job);
         }
     }
     
diff --git a/router/java/src/net/i2p/router/RouterVersion.java b/router/java/src/net/i2p/router/RouterVersion.java
index 87e5bffca0..282c18b422 100644
--- a/router/java/src/net/i2p/router/RouterVersion.java
+++ b/router/java/src/net/i2p/router/RouterVersion.java
@@ -18,7 +18,7 @@ public class RouterVersion {
     /** deprecated */
     public final static String ID = "Monotone";
     public final static String VERSION = CoreVersion.VERSION;
-    public final static long BUILD = 1;
+    public final static long BUILD = 2;
 
     /** for example "-test" */
     public final static String EXTRA = "";
diff --git a/router/java/src/net/i2p/router/message/OutboundClientMessageOneShotJob.java b/router/java/src/net/i2p/router/message/OutboundClientMessageOneShotJob.java
index 566c33970c..689339b5db 100644
--- a/router/java/src/net/i2p/router/message/OutboundClientMessageOneShotJob.java
+++ b/router/java/src/net/i2p/router/message/OutboundClientMessageOneShotJob.java
@@ -685,8 +685,8 @@ public class OutboundClientMessageOneShotJob extends JobImpl {
                     if (skm != null)
                         tsh = skm.tagsDelivered(_encryptionKey, sessKey, tags);
             }
-            onReply = new SendSuccessJob(getContext(), sessKey, tsh, replyLeaseSet);
             onFail = new SendTimeoutJob(getContext(), sessKey, tsh);
+            onReply = new SendSuccessJob(getContext(), sessKey, tsh, replyLeaseSet, onFail);
             long expiration = Math.max(_overallExpiration, _start + REPLY_TIMEOUT_MS_MIN);
             selector = new ReplySelector(token, expiration);
         }
@@ -747,8 +747,7 @@ public class OutboundClientMessageOneShotJob extends JobImpl {
                 } else {
                     // We put our own timeout on the job queue before the selector expires,
                     // so we can keep waiting for the reply and restore the tags (success-after-failure)
-                    // The timeout job will always fire, even after success.
-                    // We don't bother cancelling the timeout job as JobQueue.removeJob() is a linear search
+                    // We cancel the timeout job in the success job
                     getContext().messageRegistry().registerPending(_selector, _replyFound, null);
                     _replyTimeout.getTiming().setStartAfter(_overallExpiration);
                     getContext().jobQueue().addJob(_replyTimeout);
@@ -1004,6 +1003,7 @@ public class OutboundClientMessageOneShotJob extends JobImpl {
         private final SessionKey _key;
         private final TagSetHandle _tags;
         private final LeaseSet _deliveredLS;
+        private final SendTimeoutJob _replyTimeout;
         
         /**
          * Create a new success job that will be fired when the message encrypted with
@@ -1013,12 +1013,15 @@ public class OutboundClientMessageOneShotJob extends JobImpl {
          * @param key may be null
          * @param tags may be null
          * @param ls the delivered leaseset or null
+         * @param timeout will be cancelled when this is run
          */
-        public SendSuccessJob(RouterContext enclosingContext, SessionKey key, TagSetHandle tags, LeaseSet ls) {
+        public SendSuccessJob(RouterContext enclosingContext, SessionKey key,
+                              TagSetHandle tags, LeaseSet ls, SendTimeoutJob timeout) {
             super(enclosingContext);
             _key = key;
             _tags = tags;
             _deliveredLS = ls;
+            _replyTimeout = timeout;
         }
         
         public String getName() { return "Outbound client message send success"; }
@@ -1060,6 +1063,7 @@ public class OutboundClientMessageOneShotJob extends JobImpl {
                         skm.tagsAcked(_encryptionKey, _key, _tags);
                 }
             }
+            getContext().jobQueue().removeJob(_replyTimeout);
 
             long sendTime = getContext().clock().now() - _start;
             if (old == Result.FAIL) {