echelon/i2p.i2p
1
0
Fork 0
forked from I2P_Developers/i2p.i2p
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

findbugs all over

Browse Source
This commit is contained in:
zzz
2020-08-19 14:50:58 +00:00
parent 797a31924d
commit cc6247fe7e
14 changed files with 23 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
router/java/src/net/i2p/router/RouterVersion.java
View File

@ -18,7 +18,7 @@ public class RouterVersion {
/** deprecated */
public final static String ID = "Monotone";
public final static String VERSION = CoreVersion.VERSION;
public final static long BUILD = 12;
public final static long BUILD = 13;
/** for example "-test" */
public final static String EXTRA = "-rc";

3
router/java/src/net/i2p/router/crypto/ratchet/ECIESAEADEngine.java
View File

@ -190,7 +190,6 @@ public final class ECIESAEADEngine {
RatchetSessionTag st = new RatchetSessionTag(tag);
SessionKeyAndNonce key = keyManager.consumeTag(st);
CloveSet decrypted;
final boolean shouldDebug = _log.shouldDebug();
if (key != null) {
decrypted = xx_decryptFast(tag, st, key, data, targetPrivateKey, keyManager);
// we do NOT retry as NS
@ -957,9 +956,11 @@ public final class ECIESAEADEngine {
/**
* No ad
*/
/*
private final byte[] encryptAEADBlock(byte data[], SessionKey key, long n) {
return encryptAEADBlock(null, data, key, n);
}
*/
/**
*

1
router/java/src/net/i2p/router/crypto/ratchet/RatchetSKM.java
View File

@ -1157,7 +1157,6 @@ public class RatchetSKM extends SessionKeyManager implements SessionTagListener
_hisIBKey = receivedKey;
// create new OB TS, delete old one
PublicKey pub = nextKeys.getPublic();
PrivateKey priv = nextKeys.getPrivate();
PrivateKey sharedSecret = ECIESAEADEngine.doDH(priv, key);
byte[] sk = new byte[32];

2
router/java/src/net/i2p/router/message/OutboundClientMessageOneShotJob.java
View File

@ -1196,7 +1196,7 @@ public class OutboundClientMessageOneShotJob extends JobImpl {
}
public void onReply() {
runJob();
super.runJob();
}
}

1
router/java/src/net/i2p/router/tunnel/pool/TunnelPoolManager.java
View File

@ -562,7 +562,6 @@ public class TunnelPoolManager implements TunnelManagerFacade {
(!_context.getBooleanPropertyDefaultTrue("router.disableTunnelTesting") ||
_context.router().isHidden() ||
_context.router().getRouterInfo().getAddressCount() <= 0)) {
Hash client = cfg.getDestination();
TunnelPool pool = cfg.getTunnelPool();
_context.jobQueue().addJob(new TestJob(_context, cfg, pool));
}