echelon/i2p.i2p
1
0
Fork 0
forked from I2P_Developers/i2p.i2p
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

More findbugs all over

Browse Source
This commit is contained in:
zzz
2018-08-26 15:13:49 +00:00
parent 1f92232253
commit e64ad7ce57
11 changed files with 23 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
apps/streaming/java/src/net/i2p/client/streaming/impl/PacketHandler.java
View File

@ -281,15 +281,13 @@ class PacketHandler {
if ( (con.getHighestAckedThrough() <= 5) && (packet.getSequenceNum() <= 5) ) {
if (_log.shouldLog(Log.INFO))
_log.info("Received additional packet w/o SendStreamID after the syn on " + con + ": " + packet);
receiveKnownCon(con, packet);
return;
} else {
if (_log.shouldLog(Log.WARN))
_log.warn("hrmph, received while ack of syn was in flight on " + con + ": " + packet + " acked: " + con.getAckedPackets());
// allow unlimited packets without a SendStreamID for now
receiveKnownCon(con, packet);
return;
}
receiveKnownCon(con, packet);
return;
}
} else {
// if it has a send ID, it's almost certainly for a recently removed connection.
@ -299,6 +297,7 @@ class PacketHandler {
recent + ' ' + packet);
}
// don't bother sending reset
// TODO send reset if recent && has data?
packet.releasePayload();
return;
}