echelon/i2p.i2p
1
0
Fork 0
forked from I2P_Developers/i2p.i2p
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Util: Warn on dubious split() regex

Browse Source
This commit is contained in:
zzz
2018-03-01 16:26:31 +00:00
parent 74dc427320
commit f0b9894e48
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
core/java/src/net/i2p/data/DataHelper.java
View File

@ -1951,7 +1951,7 @@ public class DataHelper {
* This saves about 10 microseconds (Bulldozer) on subsequent invocations.
*
* @param s non-null
* @param regex non-null
* @param regex non-null, don't forget to enclose multiple choices with []
* @throws java.util.regex.PatternSyntaxException unchecked
* @since 0.9.24
*/
@ -1966,7 +1966,7 @@ public class DataHelper {
* This saves about 10 microseconds (Bulldozer) on subsequent invocations.
*
* @param s non-null
* @param regex non-null
* @param regex non-null, don't forget to enclose multiple choices with []
* @param limit result threshold
* @throws java.util.regex.PatternSyntaxException unchecked
* @since 0.9.24
@ -1974,6 +1974,11 @@ public class DataHelper {
public static String[] split(String s, String regex, int limit) {
Pattern p = patterns.get(regex);
if (p == null) {
// catches easy mistake, and also swapping the args by mistake
if (regex.length() > 1 && !regex.startsWith("[") && !regex.equals("\r\n")) {
//(new Exception("Warning: Split on regex: \"" + regex + "\" should probably be enclosed with []")).printStackTrace();
System.out.println("Warning: Split on regex: \"" + regex + "\" should probably be enclosed with []");
}
p = Pattern.compile(regex);
patterns.putIfAbsent(regex, p);
}