echelon/i2p.i2p
1
0
Fork 0
forked from I2P_Developers/i2p.i2p
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix stop button; catch and log exceptions better

Browse Source
This commit is contained in:
zzz
2010-02-11 21:41:54 +00:00
parent 62308f26bc
commit f265db4037
5 changed files with 29 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
apps/routerconsole/java/src/net/i2p/router/web/PluginStarter.java
View File

@ -50,6 +50,7 @@ public class PluginStarter implements Runnable {
startPlugins(_context);
}
/** this shouldn't throw anything */
static void startPlugins(RouterContext ctx) {
Log log = ctx.logManager().getLog(PluginStarter.class);
Properties props = pluginProperties();
@ -61,7 +62,7 @@ public class PluginStarter implements Runnable {
try {
if (!startPlugin(ctx, app))
log.error("Failed to start plugin: " + app);
} catch (Exception e) {
} catch (Throwable e) {
log.error("Failed to start plugin: " + app, e);
}
}
@ -69,7 +70,10 @@ public class PluginStarter implements Runnable {
}
}
/** @return true on success */
/**
* @return true on success
* @throws just about anything, caller would be wise to catch Throwable
*/
static boolean startPlugin(RouterContext ctx, String appName) throws Exception {
Log log = ctx.logManager().getLog(PluginStarter.class);
File pluginDir = new File(ctx.getAppDir(), PluginUpdateHandler.PLUGIN_DIR + '/' + appName);
@ -159,7 +163,10 @@ public class PluginStarter implements Runnable {
return true;
}
/** @return true on success */
/**
* @return true on success
* @throws just about anything, caller would be wise to catch Throwable
*/
static boolean stopPlugin(RouterContext ctx, String appName) throws IOException {
Log log = ctx.logManager().getLog(PluginStarter.class);
File pluginDir = new File(ctx.getAppDir(), PluginUpdateHandler.PLUGIN_DIR + '/' + appName);