add tests, fix imports, document consts

lib/common/keys_and_cert_test.go

@@ -5,16 +5,38 @@ import (
 	"testing"
 )
 
-func keysAndCertWithoutCertificate() {
-}
-
-func keysAndCertWithKeyCertificate() {
-}
-
 func TestCertificateWithMissingData(t *testing.T) {
+	assert := assert.New(t)
+
+	cert_data := []byte{0x05, 0x00, 0x04, 0x00, 0x01}
+	data := make([]byte, 128+256)
+	data = append(data, cert_data...)
+	keys_and_cert := KeysAndCert(data)
+
+	cert, err := keys_and_cert.Certificate()
+	if assert.NotNil(err) {
+		assert.Equal("certificate parsing warning: certificate data is shorter than specified by length", err.Error())
+	}
+	cert_bytes := []byte(cert)
+	if assert.Equal(len(cert_data), len(cert_bytes)) {
+		assert.Equal(cert_bytes, cert_data, "keys_and_cert.Certificate() did not return available data when cert was missing some data")
+	}
 }
 
 func TestCertificateWithValidData(t *testing.T) {
+	assert := assert.New(t)
+
+	cert_data := []byte{0x05, 0x00, 0x04, 0x00, 0x01, 0x00, 0x00}
+	data := make([]byte, 128+256)
+	data = append(data, cert_data...)
+	keys_and_cert := KeysAndCert(data)
+
+	cert, err := keys_and_cert.Certificate()
+	assert.Nil(err)
+	cert_bytes := []byte(cert)
+	if assert.Equal(len(cert_data), len(cert_bytes)) {
+		assert.Equal(cert_bytes, cert_data, "keys_and_cert.Certificate() did not return correct data with valid cert")
+	}
 }
 
 func TestPublicKeyWithBadCertificate(t *testing.T) {