tweaks after review

apps/i2psnark/java/src/org/klomp/snark/PartialPiece.java

@@ -7,6 +7,8 @@ package org.klomp.snark;
  * It is also passed from PeerState to PeerCoordinator when
  * a piece is not completely downloaded, for example
  * when the Peer disconnects or chokes.
+ *
+ * @since 0.8.2
  */
 class PartialPiece implements Comparable {
 

apps/i2ptunnel/java/src/net/i2p/i2ptunnel/I2PTunnelClient.java

@@ -31,7 +31,9 @@ public class I2PTunnelClient extends I2PTunnelClientBase {
     public I2PTunnelClient(int localPort, String destinations, Logging l, 
                            boolean ownDest, EventDispatcher notifyThis, 
                            I2PTunnel tunnel, String pkf) throws IllegalArgumentException {
-        super(localPort, ownDest, l, notifyThis, "SynSender", tunnel, pkf);
+        super(localPort, ownDest, l, notifyThis,
+              "Standard client on " + tunnel.listenHost + ':' + localPort,
+              tunnel, pkf);
 
         if (waitEventValue("openBaseClientResult").equals("error")) {
             notifyEvent("openClientResult", "error");

apps/i2ptunnel/java/src/net/i2p/i2ptunnel/I2PTunnelHTTPClientBase.java

@@ -73,7 +73,7 @@ public abstract class I2PTunnelHTTPClientBase extends I2PTunnelClientBase implem
         _proxyList = new ArrayList(4);
     }
 
-    /** all auth @ince 0.8.2 */
+    /** all auth @since 0.8.2 */
     public static final String PROP_AUTH = "proxyAuth";
     public static final String PROP_USER = "proxyUsername";
     public static final String PROP_PW = "proxyPassword";

apps/i2ptunnel/java/src/net/i2p/i2ptunnel/I2PTunnelHTTPServer.java

@@ -355,6 +355,7 @@ public class I2PTunnelHTTPServer extends I2PTunnelServer {
         if (_log.shouldLog(Log.DEBUG))
             _log.debug("Read the http command [" + command.toString() + "]");
         
+        // FIXME we probably don't need or want this in the outgoing direction
         int trimmed = 0;
         if (command.length() > 0) {
             for (int i = 0; i < command.length(); i++) {
@@ -394,7 +395,8 @@ public class I2PTunnelHTTPServer extends I2PTunnelServer {
                 else if ("X-Accept-encoding".equalsIgnoreCase(name))
                     name = "X-Accept-encoding";
 
-                //We want to remove certain headers to improve anonymity
+                // For incoming, we remove certain headers to prevent spoofing.
+                // For outgoing, we remove certain headers to improve anonymity.
                 boolean skip = false;
                 for (String skipHeader: skipHeaders) {
                     if (skipHeader.equalsIgnoreCase(name)) {

core/java/src/net/i2p/data/SimpleDataStructure.java

@@ -28,7 +28,7 @@ public abstract class SimpleDataStructure extends DataStructureImpl {
     /** this is just to avoid lots of calls to length() */
     protected final int _length;
     
-    /** A new instance with the data set to null. Call readBytes(), setData(), or from ByteArray() after this to set the data */
+    /** A new instance with the data set to null. Call readBytes(), setData(), or fromByteArray() after this to set the data */
     public SimpleDataStructure() {
         _length = length();
     }

installer/resources/themes/console/classic/console.css

@@ -407,6 +407,10 @@ div.news li {
      text-transform: capitalize;
 }
 
+div.news h3 {
+     text-align: left !important;
+}
+
 div.news p {
      color: #330;
      font-size: 9pt;
@@ -910,4 +914,4 @@ div.footnote hr{
      margin-top: -8px;
      margin-bottom: -5px;
      margin-right: 5px;
-}
+}

installer/resources/themes/console/dark/console.css

@@ -356,6 +356,10 @@ div.news li {
      text-transform: capitalize;
 }
 
+div.news h3 {
+     text-align: left !important;
+}
+
 div.news h4 {
      border-bottom: 1px;
      border-bottom-style: dotted;
@@ -1076,4 +1080,4 @@ div.footnote hr{
      margin-top: -5px;
      margin-bottom: -5px;
      margin-right: 5px;
-}
+}

installer/resources/themes/console/light/default.css

@@ -47,7 +47,6 @@ h4 {
      margin: 5px 0 15px 0;
      padding: 5px 10px;
      background: #eef url(images/header.png) repeat-x center center;
-     text-transform: uppercase;
      letter-spacing: 0.08em;
      -moz-box-shadow: inset 0px 0px 4px 0px #bbf;
      -moz-border-radius: 4px;

installer/resources/themes/console/midnight/console.css

@@ -431,6 +431,10 @@ div.news li {
      font-weight: bold;
 }
 
+div.news h3 {
+     text-align: left !important;
+}
+
 div.news p {
      color: #eef;
      font-size: 9pt;
@@ -960,4 +964,4 @@ div.footnote hr{
      margin-top: -5px;
      margin-bottom: -10px;
      margin-right: 5px;
-}
+}

router/java/src/net/i2p/router/startup/WorkingDir.java

@@ -150,7 +150,7 @@ public class WorkingDir {
         success &= migrateJettyXml(oldDirf, dirf);
         success &= migrateClientsConfig(oldDirf, dirf);
         // for later news.xml updates (we don't copy initialNews.xml over anymore)
-        success &= (new SecureDirectory(dirf, "docs")) .mkdir();
+        success &= (new SecureDirectory(dirf, "docs")).mkdir();
 
         // Report success or failure
         if (success) {